Issue 19570 - After dmake strip=true some files still not stripped
Summary: After dmake strip=true some files still not stripped
Status: CLOSED WONT_FIX
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC4
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: Martin Hollmichel
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-14 20:17 UTC by pavel
Modified: 2005-01-31 13:59 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2003-09-14 20:17:52 UTC 
After dmake=true, some files are still not stripped:

setup in the installation set itself:

pavel@oo:~/OOo_1.1.0_czech_LinuxIntel_install> l setup
-rwxr-xr-x    1 pavel    users      105621 Sep 14 20:13 setup*
pavel@oo:~/OOo_1.1.0_czech_LinuxIntel_install> file setup
setup: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically
linked (uses shared libs), not stripped
pavel@oo:~/OOo_1.1.0_czech_LinuxIntel_install> strip setup
pavel@oo:~/OOo_1.1.0_czech_LinuxIntel_install> l setup
-rwxr-xr-x    1 pavel    users       84604 Sep 14 21:13 setup*
pavel@oo:~/OOo_1.1.0_czech_LinuxIntel_install> 

In the installed OOo:

gnomeint:                   ELF 32-bit LSB executable, Intel 80386, version 1
(SYSV), dynamically linked (uses shared libs), not stripped
javaldx:                    ELF 32-bit LSB executable, Intel 80386, version 1
(SYSV), dynamically linked (uses shared libs), not stripped
pagein:                     ELF 32-bit LSB executable, Intel 80386, version 1
(SYSV), dynamically linked (uses shared libs), not stripped

and two libraries from mozilla tarballs (libldap and libprldap). Also python is
not stripped:

pavel@oo:/tmp/OpenOffice.org1.1.0/program/python-core/bin> l python 
-rwxr-xr-x    1 pavel    users     2428879 Sep 14 02:10 python*
pavel@oo:/tmp/OpenOffice.org1.1.0/program/python-core/bin> file python 
python: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically
linked (uses shared libs), not stripped
pavel@oo:/tmp/OpenOffice.org1.1.0/program/python-core/bin> strip python
pavel@oo:/tmp/OpenOffice.org1.1.0/program/python-core/bin> l python 
-rwxr-xr-x    1 pavel    users      868904 Sep 14 21:15 python*
pavel@oo:/tmp/OpenOffice.org1.1.0/program/python-core/bin> 

Stripping those files can bring us even smaller download.
Comment 1 hjs 2003-09-17 19:24:13 UTC 
AFAIK, striping in "instsetoo" is done based on the extension ".so".
it's hardcoded somewhere in "scptools".
Comment 2 pavel 2003-09-17 19:32:24 UTC 
Yes:

scptools/source/linker/scpzip.cxx, it strips only .bin, .so, .bin.*
and .so.*. Should I add those files too or is it better to change the
build process to deliver them as .bin?
Comment 3 Martin Hollmichel 2003-10-08 11:49:29 UTC 
changing to *.bin sounds more reasonable to me. pavel, will you take
care of this. if not, reassign to me again.
Comment 4 pavel 2003-10-08 16:44:13 UTC 
Martin,

I;m sorry but I'd like to concentrate on localization and parallel
build. I'd prefer you or ause looking at it.
Comment 5 Martin Hollmichel 2003-12-19 13:23:44 UTC 
adjust target to 1.1.2 since not critical, but will try to make it for 1.1.1
Comment 6 pavel 2003-12-27 17:54:27 UTC 
jbu: striping only python files gave me:

pavel@oo:~/python> du -sh *
14M     original
8.7M    strip

Both directories contain python-core-2.2.2 directory from the just installed
1.1.1a (from CVS fix2).

Can we implement striping also for python?
Comment 7 joergbudi 2004-01-09 21:53:37 UTC 
jbu->pjanik:

Hi, python shared libs get packaged in pyuno/zipcore into a zip-file. Before
they are added to the zipfile, they get stripped, so you should only have
stripped shared libs in the installation sets already now. However, the python
executable is indeed missing, so I'll add the strip command to the pyuno/zipcore
makefile for the executable. As far as I know, the files should not be stripped
in solver, or am I wrong here ?

Bye,

Joerg
Comment 8 pavel 2004-01-10 10:58:48 UTC 
Yes, solver contains not-striped binaries:

pjanik@kajak:~/solver/645/unxlngi4.pro/bin> file *|grep -c ", stripped"
2
pjanik@kajak:~/solver/645/unxlngi4.pro/bin> file *|grep -c ", not stripped"
59

Those two binaries are directly from CVS.
Comment 9 joergbudi 2004-01-11 15:00:49 UTC 
Just commited changes of pyuno/zipcore/makefile.mk to ooo111fix2, so that shared
libs and executable now get stripped. Gives a benefit of 1.8MB on the zipfile :o).

Note that even shared libs were not stripped, because the makefile variable
$(STRIP) is empty now. Now strip itself is used.

Bye,

Joerg
Comment 10 pavel 2004-01-13 05:03:55 UTC 
@jbu: python is completely stripped in the instset now - thanks!
Comment 11 pavel 2004-04-10 22:36:57 UTC 
Updating the list of not striped binaries in ooo112fix1:

- setup in the installation set:

pavel@oo:~/OOo_cws_srx645_ooo112fix1_czech_LinuxIntel_install> ls -al setup
-rwxr-xr-x    1 pavel    users      103988 Apr 10 19:56 setup
pavel@oo:~/OOo_cws_srx645_ooo112fix1_czech_LinuxIntel_install> strip setup
pavel@oo:~/OOo_cws_srx645_ooo112fix1_czech_LinuxIntel_install> ls -al setup
-rwxr-xr-x    1 pavel    users       83164 Apr 10 22:57 setup

- program/msfontextract
- program/javaldx
- program/pagein
- program/ooovirg
- program/gnomeint
Comment 12 Martin Hollmichel 2004-04-22 11:29:28 UTC 
I also do not find the time for fixing it now, so I set target to 2.0, since
workaround is known.
Comment 13 pavel 2005-01-31 13:59:22 UTC 
I do not think this is worth fixing now ;-)

If there is a need for this, I'll provide list of files again for 2.0.
Comment 14 pavel 2005-01-31 13:59:38 UTC 
Closing.