Issue 19271 - getenv value passed to strtok & LD_LIBRARY_PATH breakage
Summary: getenv value passed to strtok & LD_LIBRARY_PATH breakage
Status: CLOSED FIXED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: OOo 1.1 RC4
Hardware: PC Linux, all
: P2 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: Olaf Felka
QA Contact: issues@installation
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-08 16:39 UTC by mmeeks
Modified: 2003-10-02 10:50 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
fix some path clobbering. (1.84 KB, patch)
2003-09-08 16:40 UTC, mmeeks 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description mmeeks 2003-09-08 16:39:42 UTC 
As above really; the strtok man page says:

       Never use these functions. If you do, note that:
              These functions modify their first argument.
              These functions cannot be used on constant strings.
              ...

This patch fixes the bug and another LD_LIBRARY_PATH clobbering; this is
necessary for some of our Linux users / people with interestingly prefix'd setups.

Thanks.
Comment 1 mmeeks 2003-09-08 16:40:01 UTC 
Created attachment 9092 [details]
fix some path clobbering.
Comment 2 Olaf Felka 2003-09-09 08:32:16 UTC 
Hi Dirk,
is this something for you?
Comment 3 dirk.voelzke 2003-09-11 14:28:44 UTC 
.
Comment 4 dirk.voelzke 2003-09-12 10:42:21 UTC 
Fixed in CWS ooo11vclrc5.
Comment 5 dirk.voelzke 2003-09-16 09:22:59 UTC 
Please verify.
Comment 6 Olaf Felka 2003-09-16 10:08:53 UTC 
Done.
Comment 7 Olaf Felka 2003-09-16 10:10:11 UTC 
Verified in:
setup2/mow/source/loader/loader.c
setup2/script/setup.sh
Comment 8 Olaf Felka 2003-09-16 14:49:41 UTC 
verified
Comment 9 Olaf Felka 2003-10-02 10:50:37 UTC 
Closed