Issue 18818 - Crash in OOo impress auto-pilot
Summary: Crash in OOo impress auto-pilot
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC3
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1.1
Assignee: ulf.stroehler
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-29 16:09 UTC by gbeauche
Modified: 2004-01-30 15:26 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
suggested fix (1.04 KB, patch)
2003-08-29 16:10 UTC, gbeauche 		no flags Details | Diff
xlsfont output (210.97 KB, text/plain)
2003-09-15 16:34 UTC, gbeauche 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description gbeauche 2003-08-29 16:09:31 UTC 
Hi,

In first step of OOo impress auto-pilot, choosing type from template will result
in a crash when OOo was started locally.

Faulty function is ExtendedFontStruct::HasUnicodeChar(). Even if you can't
reproduce it, reading it exhausts a typo and that bug condition: mnRangeCount is
-1 and call to getFontCodeRanges() yields 0. We exit with mnRangeCount left to
0. On next call to HasUnicodeChar() we skip this test and will crash later
because mpCodeRanges[] was not initialized.

BTW, isn't there a potential memory leak when we are (re)allocating memory when
mnRangeCount yields -1 again? I don't think this can happen in real world though.
Comment 1 gbeauche 2003-08-29 16:10:35 UTC 
Created attachment 8879 [details]
suggested fix
Comment 2 christof.pintaske 2003-09-01 11:09:10 UTC 
cp->hdu: i think that's yours, please have a look at it.
Comment 3 hdu@apache.org 2003-09-02 09:47:32 UTC 
I cannot reproduce it here, but if none of a font's XLFD has a known 
encoding field, this could happen indeed. Thanks for catching this and for 
the patch. I'll apply it into CWS vcl7pp1r2. 
 
I'd still love to know which encoding wasn't recognized. Could you attach 
the results of the "xlsfonts" command?
Comment 4 gbeauche 2003-09-15 16:34:46 UTC 
Created attachment 9331 [details]
xlsfont output
Comment 5 hdu@apache.org 2003-09-22 16:32:11 UTC 
Probably the "sunolglyph-1" XLFDs are at fault.

HDU->US: Please verify that it doesn't crash anymore in this situation
in CWS vcl7pp1r2. (Call me so we can manipulate a fonts.dir such as to
cause the original crash)
Comment 6 ulf.stroehler 2004-01-30 15:22:22 UTC 
Couldn't reproduce either (nor with sunolglyph-1).
Setting to Fixed/Verified anyway. Fix applied.
Comment 7 ulf.stroehler 2004-01-30 15:22:58 UTC 
.
Comment 8 ulf.stroehler 2004-01-30 15:26:03 UTC 
Closing Resolved/Verified issue.
Fix will be in forthcoming OOo 1.1.1.

@Submitter: pls. verify whether this fix solves your problem in forthcomming OOo
1.1.1 and feel free to reopen if the problem remains. Thanks.