Issue 18768 - NetBSD - icu source configure macro fix
Summary: NetBSD - icu source configure macro fix
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC3
Hardware: PC NetBSD
: P2 Trivial (vote)
Target Milestone: OOo 1.1.2
Assignee: sander_traveling
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-28 13:09 UTC by Unknown
Modified: 2004-08-12 17:32 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Proper patch (against fix1 branch) (1.24 KB, patch)
2004-05-06 21:36 UTC, pavel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Unknown 2003-08-28 13:09:39 UTC
When configure is run in icu/$OUTPATH.$INPATH/misc/build/icu/source/ it fails to detect the  
presence of tzname from <time.h>  
  
Failure to detect occurs because configure.in && generated configure fail to include stdlib.h  
which is needed by atoi() used in the tzname macro test.  Hence the test fails when it should  
not.  
  
Below is a patch for the patch icu/$OUTPATH.$INPATH/icu-2.2.patch which changes both  
configure.in && configure (since I am unable to regenerate configure myself)  
  
  
Index: icu-2.2.patch 
=================================================================== 
RCS file: /cvsroot/3rd-party/openoffice/icu/icu-2.2.patch,v 
retrieving revision 1.1.1.1 
diff -u -p -r1.1.1.1 icu-2.2.patch 
--- icu-2.2.patch       26 Aug 2003 13:55:28 -0000      1.1.1.1 
+++ icu-2.2.patch       28 Aug 2003 12:00:33 -0000 
@@ -1107,3 +1107,23 @@ 
           return tempGlyphCount; 
       }; 
 
+--- misc/build/icu/source/configure.in 2003-08-28 21:55:33.000000000 +1000 
++++ /home/work/openoffice/configure.in 2003-08-28 21:56:49.000000000 +1000 
+@@ -448,6 +448,7 @@ changequote(<<, >>)dnl 
+ <<#ifndef __USE_POSIX 
+ #define __USE_POSIX 
+ #endif 
++#include <stdlib.h> 
+ #include <time.h> 
+ #ifndef tzname /* For SGI.  */ 
+ extern char *tzname[]; /* RS6000 and others reject char **tzname.  */ 
+--- misc/build/icu/source/configure    2003-08-28 21:58:21.000000000 +1000 
++++ /home/work/openoffice/configure    2003-08-28 21:59:34.000000000 +1000 
+@@ -2964,6 +2964,7 @@ else 
+ #ifndef __USE_POSIX 
+ #define __USE_POSIX 
+ #endif 
++#include <stdlib.h> 
+ #include <time.h> 
+ #ifndef tzname /* For SGI.  */ 
+ extern char *tzname[]; /* RS6000 and others reject char **tzname.  */
Comment 1 Unknown 2003-10-01 14:00:46 UTC
This is a simple patch is there a reason why no-one has at least 
evaluated it?   It's sat unconfirmed for more than a month now. 
Comment 2 Martin Hollmichel 2003-10-23 09:51:15 UTC
confirm
Comment 3 Martin Hollmichel 2003-10-23 09:52:29 UTC
mh->svesik: will you take care to generate the correct patch ?!
Comment 4 pavel 2004-05-06 21:34:38 UTC
svesik: I did the patch for you. Attached.
Comment 5 pavel 2004-05-06 21:36:18 UTC
Created attachment 15040 [details]
Proper patch (against fix1 branch)
Comment 6 sander_traveling 2004-05-17 15:49:11 UTC
Thanx, commited in cws_srx645_ooo112fix2
Comment 7 jens-heiner.rechtien 2004-08-12 17:32:16 UTC
Closing ...