Issue 18670 - VirtualMachine::attachThread calls wrongly typed JNI function
Summary: VirtualMachine::attachThread calls wrongly typed JNI function
Status: CLOSED FIXED
Alias: None
Product: udk
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC3
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 1.1
Assignee: marc.neumann
QA Contact: issues@udk
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-26 07:58 UTC by Stephan Bergmann
Modified: 2004-01-15 13:14 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
small fix to use CallVoidMethod (680 bytes, patch)
2003-08-28 13:26 UTC, khendricks 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Stephan Bergmann 2003-08-26 07:58:52 UTC 
As Kevin Hendricks pointed out at dev@openoffice, the JNI call to
setContextClassLoader in jvmaccess/source/virtualmachine.cxx 1.2 should be made
with CallVoidMethod, not CallObjectMethod.
Comment 1 Stephan Bergmann 2003-08-26 07:59:26 UTC 
.
Comment 2 Stephan Bergmann 2003-08-26 08:08:16 UTC 
[Fixed typos in Summary.]
Comment 3 khendricks 2003-08-27 14:20:36 UTC 
Hi Stephan, 
 
For the record, since this fix is safe and impacts at least PPC Linux 's Blackdown 
JDK, PPC Linux will ship with this fix in place in OOo 1.1.0. 
 
The fix is so simple/safe perhaps we should simply target this for 1.1.1. 
 
I would be happy to commit this fix once OOo 1.1.0 goes out the door if it would help. 
 
Thanks, 
 
Kevin
Comment 4 Stephan Bergmann 2003-08-27 14:28:48 UTC 
SB->Kevin:  Sounds reasonable to me too to include the fix ASAP.  Did
I understand you right that you want to take ownership of this issue?
Comment 5 khendricks 2003-08-27 15:51:47 UTC 
Hi Stephan, 
 
Is msx645 tree still open for non-crashing bug fixes.  If so, then let's please get this 
into the tree so that it appears in OOo 1.1.0. 
 
If not, and iif therefore it must me held for some later release, I would be happy to 
remember to commit it to the tree the next time it is open (if that means take 
ownership, then that is fine with me!). 
 
I agree a better solution would be to get this into OOo 1.1 final and forget (i.e. close 
this but I was unsure if fixes like this were still being accepted. 
 
Kevin
Comment 6 Stephan Bergmann 2003-08-27 16:18:09 UTC 
SB->Kevin:  According to Martin Hollmichel, there's no chance to get
this into OOo 1.1.0.  So, lets keep it targeted for OOo 1.1.1.  And,
thanks that you will commit it then.
Comment 7 Martin Hollmichel 2003-08-28 13:06:41 UTC 
mh: please attach the patch.

if we make another resping for 1.1.0 I will take this one also into
release.
Comment 8 khendricks 2003-08-28 13:26:23 UTC 
Created attachment 8845 [details]
small fix to use CallVoidMethod
Comment 9 Stephan Bergmann 2003-08-29 11:53:09 UTC 
SB->Kevin:  I just got asked in-house to "fast-track" add this fix to
SRX645 (i.e., OOo 1.1.0), which I did.  So I'm tacking over again. 
(PS:  I was so "fast-track" I failed to mention in the cvs log that
the fix actually comes from you; sorry for that omisson.)
Comment 10 Stephan Bergmann 2003-08-29 16:19:30 UTC 
Set target to "OOo 1.1" to reflect reality.
Comment 11 Stephan Bergmann 2003-09-03 07:59:08 UTC 
SB->MSC:  Please test that Java within Office still works on all
platforms (e.g., File-AutoPilot-Report...; or loading a document
containing a Java applet).
Comment 12 marc.neumann 2003-09-03 09:26:03 UTC 
set to fixed
Comment 13 marc.neumann 2003-09-03 09:27:00 UTC 
verified in m17-6.

Report wizard still works and HTML document with applet works too.
Comment 14 marc.neumann 2004-01-15 13:14:59 UTC 
close.