Issue 18440 - beep mania ...
Summary: beep mania ...
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC3
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1.1
Assignee: philipp.lohmann
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-20 12:14 UTC by mmeeks
Modified: 2004-01-27 10:19 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description mmeeks 2003-08-20 12:14:24 UTC 
By extensive experminentation, it has been shown that OO.o when deployed on a
machine adjacent to another co-worker, causes a constant stream of beeps to
annoy everyone ;-)

[ ok - so I confess, I only got one report of this, but it was easy to clobber
so ... ].

Something like this may help:

--- vcl/unx/source/window/salframe.cxx  1 Jul 2003 14:49:01 -0000       1.163
+++ vcl/unx/source/window/salframe.cxx  20 Aug 2003 11:03:39 -0000
@@ -2271,7 +2271,17 @@ bool SalFrame::SetPluginParent( SystemPa
 // Sound
 // -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 void SalFrame::Beep( SoundType eSoundType ) // not fully suported
-{ _GetDisplay()->Beep(); }
+{
+       switch (eSoundType) {
+       case SOUND_DEFAULT:
+       case SOUND_ERROR:
+               _GetDisplay()->Beep();
+               break;
+       default:
+               // Excessive beeping averted
+               break;
+       }
+}
 
Interested ?
Comment 1 philipp.lohmann 2003-08-21 11:38:12 UTC 
I think it would be better to find the culprit who calls that method
to often. Perhaps he has a reason like "my database is on fire" :-)
Comment 2 mmeeks 2003-08-21 12:19:06 UTC 
Heh ;-)

the patch allows Sound::Beep() to continue working, but bins a beep
for all 'information', 'warning', 'query' etc. dialog boxes.
Comment 3 christof.pintaske 2003-09-01 14:21:20 UTC 
cp->mmp request for comments: looks like as if we are blindly playing
the same sound for each and every notification level. Is this behavior
specified ? I tend to follow Michaels suggestion to reduce it in the
short term. In the mid/long term we should do some more system
integration (play gnome complient sounds ?) 
afaik in Japan probably half of the office staff will think that you
are a duffer if your desktop makes funny noises.
Comment 4 matthias.mueller-prove 2003-09-09 17:10:17 UTC 
MMP>CP: I agree. The hot-fix sounds ;-) reasonable. Let's just beep on
stop alerts. On the long run we should further investigate this issue
(sys integration and the like).  Is it possible to change it for PP1?
Comment 5 christof.pintaske 2003-09-10 09:53:59 UTC 
cp->pl: please find a really nice cws for this one
Comment 6 philipp.lohmann 2003-09-12 14:07:14 UTC 
fixed in CWS vcl7pp1r3
Comment 7 philipp.lohmann 2003-11-13 09:42:49 UTC 
verified that changes got into CWS vcl7pp1r3
Comment 8 philipp.lohmann 2004-01-27 10:19:38 UTC 
integrated in 645m25s1