Issue 18165 - crashrep build breaks with default configure flags
Summary: crashrep build breaks with default configure flags
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC3
Hardware: PC Linux, all
: P2 Trivial (vote)
Target Milestone: OOo 1.1
Assignee: hennes.rohling
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks: 17790
  Show dependency tree
 
Reported: 2003-08-12 19:56 UTC by chris
Modified: 2003-09-30 14:39 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description chris 2003-08-12 19:56:23 UTC 
I ran configure 

/oo/openoffice.org-1.0.99+1.1rc2pre3/build-tree/oo_1.1prerc3_src/crashrep/source/unx
------------------------------
Making: ../../unxlngi4.pro/bin/crash_report_with_gtk.bin
unx
--only-mod-libs: unknown option
dmake:  Error code 1, while making
'../../unxlngi4.pro/bin/crash_report_with_gtk.bin'

When the crash reporter is enabled, the makefile tests for
PRODUCT="FULL", but PRODUCT="full" as generated by config_office, so
the static build is attempted even though I did not request it.

I guess to fix the we need to set PRODUCT="FULL" in
config_office/set_soenv.in?
Comment 1 pavel 2003-08-12 20:00:54 UTC 
Confirmed. I forgot to report that, because I have this in my patches:

--- ooo_11rc3_src.orig/scp/util/makefile.mk	Tue Aug  5 20:14:06 2003
+++ ooo_11rc3_src/scp/util/makefile.mk	Tue Aug  5 20:19:19 2003
@@ -152,6 +152,8 @@
 
 .ENDIF
 
+.IF "Crashrep" == "reallyworks"
+
 .IF "$(ENABLE_CRASHDUMP)" != "" || "$(PRODUCT)" != "FULL" 
 SCP1FILES += \
         crashrep_dynamic.par
@@ -164,6 +166,8 @@
 .ENDIF
 .ENDIF
 
+.ENDIF
+
 # --- target
-------------------------------------------------------------
 .INCLUDE :  target.mk
Comment 2 Martin Hollmichel 2003-08-13 08:12:25 UTC 
PRODUCT=full is valid for configure and setsolar, so I think this is
the correct value.
Comment 3 khendricks 2003-08-20 16:37:49 UTC 
Hi, 
 As of today in rc4, we need to change or remove the  || $(PRODUCT)!="FULL" in 
crashrep/source/unx/makefile.mk AND in scp/util/makefile.mk to get this to actually 
build. 
 
I would be happy to either remove the extra || condition or to change all of these from 
"FULL" to "full" in all impacted files and commit them if someone can approve either 
sytle of change. 
 
Kevin
Comment 4 hennes.rohling 2003-08-20 17:18:08 UTC 
accepted
Comment 5 hennes.rohling 2003-08-21 10:50:28 UTC 
Changed test for a non-product build to "$(PRODUCT)"=="". Changes
commited on branch mws_srx645.

scp/util/makefile.mk revision 1.24.24.1
crash/source/unx/makefile.mk revision 1.7.10.2
Comment 6 rt 2003-08-21 11:00:08 UTC 
scp/util/makefile.mk revision 1.24.24.1
crash/source/unx/makefile.mk revision 1.7.10.2

are tagged now with OpenOffice_1_1_rc4

Rüdiger
Comment 7 hennes.rohling 2003-09-30 14:39:35 UTC 
closed.