Issue 18065 - FreeBSD-4.8: error in vcl/unx/source/app/salmain.cxx
Summary: FreeBSD-4.8: error in vcl/unx/source/app/salmain.cxx
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC2
Hardware: PC FreeBSD
: P3 Trivial (vote)
Target Milestone: OOo 1.1.1
Assignee: Martin Hollmichel
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks: 18060
  Show dependency tree
 
Reported: 2003-08-09 10:26 UTC by quetschke
Modified: 2004-02-07 10:09 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for vcl/unx/source/app/salmain.cxx (604 bytes, patch)
2003-08-09 10:28 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2003-08-09 10:26:50 UTC 
Error while compiling salmain.cxx:

In file included from
/home/q/work/cws_srx645_ooo11rc3/vcl/unx/source/app/salmain.cxx:71:
/usr/include/sys/resource.h:58: error: field `ru_utime' has incomplete type
/usr/include/sys/resource.h:59: error: field `ru_stime' has incomplete type
/usr/include/sys/resource.h:119: error: 'int32_t' is used as a type, but is not 
   defined as a type.

Problem:
/usr/include/sys/resource.h uses `struct timeval` in the definition of
struct rusage.  struct timeval is defined in /usr/include/sys/time.h, 
but <sys/time.h> is not included in the <sys/resource.h> header file.

The following patch fixes this, but it doesn't make differences for the used
OSVERSION. It is necessary to version this between FreeBSD 4.8 to 5.x, or it
is ok to include the headers also in 5.x?
Comment 1 quetschke 2003-08-09 10:28:43 UTC 
Created attachment 8362 [details]
Patch for vcl/unx/source/app/salmain.cxx
Comment 2 quetschke 2003-08-09 10:29:53 UTC 
Target 1.1.1
Comment 3 maho.nakata 2003-08-10 16:28:33 UTC 
Hi Volker,
The structure is defined in <sys/time.h> on 5-CURRENT.
I saw the man and /usr/include/sys/time.h.
on 5-CURRENT sys/time.h includes sys/_timeval.h and here,
actually defined struct timeval.
So you are correct.
Comment 4 philipp.lohmann 2003-08-11 07:39:47 UTC 
pl->mh: please apply in next OOo CWS.
Comment 5 quetschke 2003-10-10 00:16:05 UTC 
Committed to cws_srx645_ooo111fix1.
Comment 6 Martin Hollmichel 2004-02-07 10:07:47 UTC 
mark as verified.
Comment 7 Martin Hollmichel 2004-02-07 10:09:51 UTC 
close issue.