Apache OpenOffice (AOO) Bugzilla – Issue 17764
Any change tracking in a texttable is lost if the table is altered
Last modified: 2013-08-07 14:41:36 UTC
If change tracking is enabled and the document has a text table, if there is a change to the text in the table and table is modified, i.e. by spliting a cell or by adding cells, all tracking is losed in the table.
This is a known design/implementation problem. We want to solve it for OOo 2.0.
Removing instances of lcl_DelRedline in sw/source/docnode/ndtbl.cxx seems to fix this issue for most cases. The only case that this did not fix was merging cells.
SBA: Note that there is an (internal) issue about this too (bt4903294).
dsherwin->SBA: Can you mark the internal bugtracker issue (bt4903294) as duplicate of this issue, as this affects both OOo and SO?
.
Turning off lcl_DelRedlines in sw/source/core/docnode/ndtbl.cxx overcomes most of the issues. I have tried approx 100 operations on the table with plenty of undo/redo and no redlines were lost. The only case left is the merging of cells.
According to the OpenOffice.org roadmap (http://tools.openoffice.org/releases) this issue was retargeted to OOo Later.
Could be connected with Issue 21670?
*** Issue 33564 has been marked as a duplicate of this issue. ***
dvo: OK... The reason this was not fixed in the past is that properly solving table redlines problems would require a significant re-design of the redlining code, which no one has undertaken so far. The problem is... this gets requested over and over again, and deep down we all know the users are actually right... One possibility is to simply disable the code which removes the redlines (as dsherwin has already tried out). That is easy to do but unfortunately rather risky, in that the original developer warned us from doing this without the bespoke redline redesign. What we would like to do is to include this into a development or beta version and get it into the public, and possibly roll back the changes if they prove trouble-some. I'm quite optimistic however, particularly since Darragh appears not to have run into any problems. I have introduces a new define DEL_TABLE_REDLINES into sw/source/core/docnode/ndtbl.cxx, and wrapped all changes for this issue into suitable ifdefs. Enabling the define will fully restore the previous behaviour. dvo->mru: Please test. Have fun. :-) No, really!
*** Issue 25944 has been marked as a duplicate of this issue. ***
dvo: Reopen for QA.
dvo->mru: Please test.
Should have state "fixed".
Reopened.
MRU->DVO: due to the Assertions which rise when working with Redlines in tables, me and AMA decided to move the fix to a different CWS.
dvo: Fixed in swtableredline. Will send to QA after more thorough testing.
*** Issue 41485 has been marked as a duplicate of this issue. ***
CC'ing Aidan on this issue
dvo: Found & fixed several problems when merging cells with redlines. Example: +-----------+ | abc | +-----------+ | defghi | +-----------+ When one of 'abc' or 'def' is redlined and the cells are merged, the redlining would do funny stuff. Also, when there was a bookmark, OOo would crash after cell merge + undo.
ES->DVO: I tortured the Writer with redlining in tables, deleting insertin, merging, splitting, with bookmarks, frames to characters, undo and redo -> no redlining loss, no crash! Great job! Verified in CWS swtableredline
reopen
Ressaigned
fixed
VERIFIED
*** Issue 45889 has been marked as a duplicate of this issue. ***
Ok in SRC680m90
*** Issue 8446 has been marked as a duplicate of this issue. ***
*** Issue 9665 has been marked as a duplicate of this issue. ***
*** Issue 77822 has been marked as a duplicate of this issue. ***
*** Issue 3460 has been marked as a duplicate of this issue. ***