Issue 17522 - crashdump conditionals
Summary: crashdump conditionals
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC2
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: Martin Hollmichel
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-28 18:50 UTC by mmeeks
Modified: 2004-02-07 10:09 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description mmeeks 2003-07-28 18:50:53 UTC 
This patch stops the crashrep stuff being installed, when crashdump isn't enabled;

--- scp/source/office/files.scp 17 Jul 2003 08:54:46 -0000      1.367
+++ scp/source/office/files.scp 28 Jul 2003 17:48:42 -0000
@@ -235,6 +235,8 @@ End
 
 #endif
 
+#ifdef ENABLE_CRASHDUMP
+
 #ifndef MACOSX
 // crashreporter files
 
@@ -279,6 +281,8 @@ File GID_FILE_RES_CRASHDUMP
 End
 #endif
 #endif
+
+#endif /* ENABLE_CRASHDUMP */
 
 // special files for migration for 5.2 to 6.0
Comment 1 foskey 2003-07-30 12:35:40 UTC 
crash dump is a vq speciality.
Comment 2 quetschke 2003-07-30 13:05:15 UTC 
Well, up to now I didn't do anything with the installer.

Martin or Kevin would be good to ask, but I'm sure ause
can also approve in this area.
Comment 3 mmeeks 2003-07-30 17:57:22 UTC 
Kevin ?
Comment 4 pavel 2003-08-01 19:24:04 UTC 
I used something similar in the past because our build systems do not
contain pkg-config thus crashrep can not be build.

Currently even if you build without crashrep, your installation
process wants to install its files and issues warning to user. This
applies only to interactive installer. ./install --prefix=/tmp will fail.
Comment 5 Martin Hollmichel 2003-08-05 10:55:23 UTC 
mh->is: please take a look on this.
Comment 6 ingo.schmidt-rosbiegal 2003-08-05 11:51:31 UTC 
This is already fixed with bug #17635, which will be included in
ooo11rc3. It was an error, that the crahsrep-files were still included
into the files.scp. Instead I created before the new subdirectory
scp/source/crashrep, where I defined the files crashrep_static.scp
(with the crash_report_with_gtk.bin) and crashrep_dynamic.scp (with
the other crashrep files from files.scp). files.scp will not contain
any crashrep-files in the future.
In scp/util/makefile.mk you can see, at which conditions the crashrep
files are included in the OpenOffice.org product:

.IF "$(ENABLE_CRASHDUMP)" != "" || "$(PRODUCT)" != "FULL" 
SCP1FILES += \
        crashrep_dynamic.par
.ENDIF

.IF "$(GUI)"=="UNX"
.IF "$(ENABLE_CRASHDUMP)" == "STATIC" || "$(PRODUCT)" != "FULL"
SCP1FILES += \
        crashrep_static.par
.ENDIF
.ENDIF

Therefore this bug is obviously already fixed.
Comment 7 ingo.schmidt-rosbiegal 2003-09-09 15:18:46 UTC 
If everything works fine now, you can close this bug.
Comment 8 mmeeks 2003-09-09 17:26:57 UTC 
fixed in RC4; thanks.
Comment 9 Martin Hollmichel 2004-02-07 10:07:23 UTC 
mark as verified.
Comment 10 Martin Hollmichel 2004-02-07 10:09:22 UTC 
close issue.