Issue 17190 - email URL not exported correctly to Docbook
Summary: email URL not exported correctly to Docbook
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: external filters (show other issues)
Version: OOo 1.1 RC
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 1.1.1
Assignee: jogi
QA Contact: issues@xml
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-21 17:35 UTC by con.hennessy
Modified: 2003-12-19 11:27 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description con.hennessy 2003-07-21 17:35:41 UTC 
When I insert a link in a Writer doc with the URL "mailto:users@openoffice.org"  
it is generated into docbook as : 
<olink targetdocent="mailto:users@openoffice.org">users@openoffice.org </olink> 
However from my understanding of docbook it should really be  
<ulink href="mailto:users@openoffice.org">users@openoffice.org </ulink> 
 
I've seen this info : 
"Unlike Link and ULink, the semantics of OLink are application-specific. OLink  
provides a mechanism for establishing links across documents, where ID/IDREF  
linking is not possible and ULink is inappropriate." 
at http://www.docbook.org/tdg/en/html/olink.html 
and "The ULink element forms the equivalent of an HTML anchor (<A HREF="...">)  
for cross reference by a Uniform Resource Locator (URL)." at : 
http://www.docbook.org/tdg/en/html/ulink.html
Comment 1 jogi 2003-07-22 06:59:16 UTC 
JSI-> James: Your turn.
Comment 2 jcleere 2003-08-06 16:10:28 UTC 
Lars is now responsible for this transformation
Comment 3 lo 2003-08-12 15:35:33 UTC 
taking over
Comment 4 con.hennessy 2003-08-21 10:31:42 UTC 
The fix I have made to my own version of sofftodocbookheadings.xsl is  
around line 833: 
              <xsl:when test="contains(@xlink:href,'mailto:')"> 
                       <xsl:element name="email"> 
                                       <xsl:value-of select="substring-after(@xlink:
href,'mailto:')"/> 
                       </xsl:element> 
               </xsl:when>
Comment 5 lo 2003-09-19 11:40:49 UTC 
fix from cphennessy has been commited to cws fwk01pp1 -> OOo 1.1.1
Comment 6 lo 2003-10-28 10:17:58 UTC 
ready for QA
Comment 7 lo 2003-11-06 12:17:40 UTC 
reviewing this with QA and it seems a bit strange
fix produces email element not ulink as in first description ( no
reimport possible) , first description asks for @href but ulink uses
@url...
new fix:
use <ulink url="mailto:...">...</ulink> for <text:a
xlink:href="mailto:...">...</text:a>
Comment 8 jogi 2003-11-06 12:19:17 UTC 
<email> is not the tag we want to use :-( <ulink.... would be better.
Comment 9 lo 2003-11-06 14:41:58 UTC 
redone on fwk01pp1
Comment 10 jogi 2003-11-07 13:53:57 UTC 
Automated DocBook test has been finished and seems to be no regression
in this fix. Will have a look manually to some functionality around it.
Comment 11 jogi 2003-11-07 13:54:57 UTC 
Setting resolution.
Comment 12 jogi 2003-11-13 06:35:09 UTC 
automated DocBook test has been finished.
Comment 13 jogi 2003-11-13 06:37:02 UTC 
grrr. searching the correct resolution :-(
Comment 14 jogi 2003-11-13 06:37:31 UTC 
Fixed.
Comment 15 jogi 2003-11-13 06:38:04 UTC 
Now it is correct: verified.
Comment 16 jogi 2003-12-19 11:27:14 UTC 
JSI: Okay in FIX645m3