Issue 17182 - list-box click ergnonomics ...
Summary: list-box click ergnonomics ...
Status: CLOSED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: stefan.baltzer
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-21 16:22 UTC by mmeeks
Modified: 2004-04-26 21:16 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description mmeeks 2003-07-21 16:22:19 UTC 
If you have a really short string in a list box; you have to be annoyingly
precise in clicking on it; this patch makes the whole row sensitive, and these
lists easier to use.

--- svtools/source/contnr/svimpbox.cxx	Fri Dec  7 09:40:39 2001
+++ svtools/source/contnr/svimpbox.cxx	Wed Jan  8 16:40:55 2003
@@ -676,6 +676,7 @@
 		return TRUE;
 
 	Rectangle aRect( pView->GetFocusRect( pEntry, nLine ));
+	aRect.Right () = GetOutputSize().Width() - pView->GetMapMode().GetOrigin().X();
 	if( pView->IsA() == SV_LISTBOX_ID_TREEBOX )
 	{
 		SvLBoxContextBmp* pBmp =
(SvLBoxContextBmp*)(pEntry->GetFirstItem(SV_ITEM_ID_LBOXCONTEXTBMP));

may I commit ?
Comment 1 christof.pintaske 2003-07-22 13:37:51 UTC 
cp->mmeeks: svtools belongs to utilities project (don't ask me why)
cp->gt: hi gunnar, could you or frank have a look at the patch ? cvs
blames you for being familiar with the code.
Comment 2 gunnar.timm 2003-07-22 14:51:11 UTC 
gt->mmeeks: It's not yet clear, how this affects the handling of the
scroll bar. But this should work because the mouse event of the scroll
bar is handled before the entire control.
Additionally the move of the bitmap afterwards could cause some glidges.
Another thing is that there should be an area from the boundary of the
entry / scroll bar, where the entry is not hit. Don't know the size of
this distance at moment.

I've set the target to 2.0 because it's simply the next after the
RC... ;-)
Comment 3 mmeeks 2003-07-24 17:58:10 UTC 
Hi Gunnar, it seems we have more milestones now - any chance of this
in 1.1.1 ? I'm happy to add a fudge factor to protect the scroll-bar;
presumably that will be a small number of pixels though (?)
Comment 4 gunnar.timm 2004-02-20 13:51:15 UTC 
CWS gt03
Comment 5 gunnar.timm 2004-03-29 09:01:51 UTC 
.
Comment 6 stefan.baltzer 2004-03-31 13:53:42 UTC 
SBA: Verified in CWS gt05.
Comment 7 stefan.baltzer 2004-03-31 13:56:21 UTC 
SBA: Marked verified.
Comment 8 stefan.baltzer 2004-04-26 21:16:55 UTC 
SBA: OK in Build 680m34. Closed.