Issue 17026 - configure.in glups AC_SUBSTs together
Summary: configure.in glups AC_SUBSTs together
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: foskey
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-17 14:58 UTC by mmeeks
Modified: 2003-12-25 05:10 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
move around the variables to keep them together (15.83 KB, patch)
2003-07-18 10:59 UTC, foskey 		no flags Details | Diff
correct some features in code as well. clean up more (29.98 KB, patch)
2003-07-18 14:34 UTC, foskey 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description mmeeks 2003-07-17 14:58:42 UTC 
It's fairly bad news for patches to configure.in to have all the AC_SUBSTs
clumped up at the bottom of the file - most projects do these by the code that
sets them - so it's easier to read/see that these are exported; so the big block
at the end just needs pushing back up to near each check.

Thanks :-)
Comment 1 foskey 2003-07-18 10:59:04 UTC 
Created attachment 7835 [details]
move around the variables to keep them together
Comment 2 foskey 2003-07-18 10:59:50 UTC 
Please verify on both types of NT and approve patch.  Ta Ken
Comment 3 foskey 2003-07-18 14:34:44 UTC 
Created attachment 7844 [details]
correct some features in code as well.  clean up more
Comment 4 quetschke 2003-07-19 23:02:06 UTC 
Hi Ken,

looks good by inspection, approved.

I will test later today, if I overlooked something, I will fix it.
(At least for win ;-) )
Comment 5 foskey 2003-07-21 06:32:02 UTC 
Waiting for Sanders final approval.
Comment 6 foskey 2003-07-24 14:16:59 UTC 
This has been fixed in RC3
Comment 7 foskey 2003-12-20 13:45:46 UTC 
verified.
Comment 8 foskey 2003-12-25 05:10:02 UTC 
closing