Issue 1676 - Can't open Word Files in OO 638
Summary: Can't open Word Files in OO 638
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: 638
Hardware: PC Windows 2000
: P2 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords:
: 1836 (view as issue list)
Depends on:
Blocks:
 
Reported: 2001-09-15 05:00 UTC by Unknown
Modified: 2003-09-08 16:56 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
First Attachment that can't be open (678.12 KB, application/octet-stream)
2001-09-15 05:01 UTC, Unknown 		no flags Details
Second attachment that can't be opened (45.89 KB, application/octet-stream)
2001-09-15 05:02 UTC, Unknown 		no flags Details
Third document that can't be opened (409.42 KB, application/octet-stream)
2001-09-15 05:02 UTC, Unknown 		no flags Details
Shorter document with grouped objects (109.00 KB, application/msword)
2001-10-09 16:01 UTC, michael.ruess 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Unknown 2001-09-15 05:00:25 UTC 
The following 3 attachments are created by MicroSoft Word and can be open using 
Word 97. When try to open using OO 638, a unrecoverable error was reported.
 
These Word documents are actual and serious work, not generated for testing 
purpose, so the user was using quite some features in MS-Word.
Comment 1 Unknown 2001-09-15 05:01:22 UTC 
Created attachment 509 [details]
First Attachment that can't be open
Comment 2 Unknown 2001-09-15 05:02:03 UTC 
Created attachment 510 [details]
Second attachment that can't be opened
Comment 3 Unknown 2001-09-15 05:02:55 UTC 
Created attachment 511 [details]
Third document that can't be opened
Comment 4 michael.ruess 2001-09-19 13:17:15 UTC 
Reassigned to mru.
Comment 5 michael.ruess 2001-10-09 15:58:21 UTC 
It crashes in the Drawing Layer (Stack with 641e1). The files contain
groups of graphics and text objects. When I ungroup them in Winword
and them import the file into Writer, the crash doesn´t occur.
I´ll attach a shorter document which shows the problem.
Comment 6 michael.ruess 2001-10-09 16:01:48 UTC 
Created attachment 570 [details]
Shorter document with grouped objects
Comment 7 michael.ruess 2001-10-11 10:16:53 UTC 
*** Issue 1836 has been marked as a duplicate of this issue. ***
Comment 8 sven.jacobi 2001-10-12 14:19:41 UTC 
I will take care of this bug soon.
Comment 9 sven.jacobi 2001-10-16 13:51:17 UTC 
Hi Caolan,

the problem is located in ww8graf.cxx in line 2578. A object is 
accessed that has already been deleted.

if( bEraseThisObject )
{
   if( pGroupObject || (pSdrTextObj != pTrueObject) )
   {
      SdrObject* pNewObj = pGroupObject ?
          pGroupObject->GetSubList()->GetObj(nOrdNum) : pTrueObject;
      pMSDffManager->ExchangeInShapeOrder(pSdrTextObj, 0,0, pNewObj);
      delete pRecord->pObj;   //2578 !! pObj can be equal to pNewObj
      pRecord->pObj = pNewObj;
   }
}

The crash can been fixed easily, but the question here is, if it is 
correct to replace the object there. It will be good if you can  
evaluate this.

Have fun,
Sven
Comment 10 caolanm 2001-10-17 11:21:36 UTC 
cmc: hmm, very dodgy logic. Fix checked in.
Comment 11 caolanm 2001-10-24 10:21:52 UTC 
Crash begone in 641i
Comment 12 michael.ruess 2001-10-25 11:15:32 UTC 
Now fixed for OpenOffice 641.
Comment 13 michael.ruess 2001-12-04 12:40:49 UTC 
Works with OO641.