Issue 16698 - IRIX: python makefile needs changes
Summary: IRIX: python makefile needs changes
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: SGI IRIX
: P2 Trivial (vote)
Target Milestone: ---
Assignee: Martin Hollmichel
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-11 02:54 UTC by nickb
Modified: 2004-02-06 17:22 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
python/makefile.mk - IRIX changes (use gmake and IRIX link line) (1.32 KB, patch)
2003-07-11 02:57 UTC, nickb 		no flags Details | Diff
curl/makefile.mk - IRIX should call gmake, not make (646 bytes, patch)
2003-07-11 03:10 UTC, nickb 		no flags Details | Diff
Fix Solaris double ld (1.48 KB, patch)
2003-07-12 10:24 UTC, pavel 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description nickb 2003-07-11 02:54:46 UTC 
Two small changes, firstly, we need to explicitly call gmake, not make (smake is
not compatible with gmake), secondly, we need an IRIX specific link line.

On a general note, couldn't we call gmake on ALL platforms? If we are using
gmake Makefiles, then we should explicitly call it.
Comment 1 nickb 2003-07-11 02:57:34 UTC 
Created attachment 7565 [details]
python/makefile.mk - IRIX changes (use gmake and IRIX link line)
Comment 2 nickb 2003-07-11 03:10:25 UTC 
Created attachment 7566 [details]
curl/makefile.mk - IRIX should call gmake, not make
Comment 3 nickb 2003-07-11 03:10:38 UTC 
curl has a similar problem.
Comment 4 nickb 2003-07-11 05:21:44 UTC 
Added target milestone
Comment 5 Martin Hollmichel 2003-07-11 10:41:25 UTC 
committed to ooo11rc2.
Comment 6 quetschke 2003-07-11 16:18:47 UTC 
Just a comment:

We have the variable $GNUMAKE for this purpose, no need for if ...
constructions.

Volker
Comment 7 pavel 2003-07-12 10:21:55 UTC 
Martin,

you merged python patch wrong, because for Solaris, the else case of
IRIX is executed resulting in wrong second (GNU) ld command.

python-fix-for-solaris.diff fixes it.
Comment 8 pavel 2003-07-12 10:24:21 UTC 
Created attachment 7608 [details]
Fix Solaris double ld
Comment 9 Martin Hollmichel 2003-07-14 13:49:22 UTC 
committed to ooo11rc2.
Comment 10 Martin Hollmichel 2003-07-16 08:37:33 UTC 
verified.
Comment 11 Martin Hollmichel 2004-02-06 17:22:02 UTC 
close issue.