Issue 16664 - ByteString::ToDouble non-existant, and warning-less
Summary: ByteString::ToDouble non-existant, and warning-less
Status: CLOSED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: Stephan Bergmann
QA Contact: Unknown
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-10 16:29 UTC by mmeeks
Modified: 2003-08-18 09:00 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description mmeeks 2003-07-10 16:29:22 UTC 
The code says it all:

float ByteString::ToFloat() const
{
	DBG_CHKTHIS( ByteString, DbgCheckByteString );

	return 0;
}

double ByteString::ToDouble() const
{
	DBG_CHKTHIS( ByteString, DbgCheckByteString );

	return 0;
}

Is this a feature ? - it wasted a load of my time, can't we just chain to the
rtl:: versions ?
Comment 1 hennes.rohling 2003-07-10 17:00:59 UTC 
@sb: Is there any reason why these methods do not call
rtl_str_ToDouble and rtl_str_ToFloat ? 
The UniString methods do so.

IMHO we should depredicate the ByteStrings at all.
Comment 2 jens-heiner.rechtien 2003-07-10 17:07:47 UTC 
Michael,

you have my full sympathy ...

I can't believe that such stupid things survived for years in our code
base :-(

Heiner
Comment 3 Stephan Bergmann 2003-07-10 17:19:08 UTC 
Either fix this or remove tools Uni/ByteString (in favor of rtl
strings), whatever happens first...
Comment 4 Stephan Bergmann 2003-07-11 07:43:17 UTC 
.
Comment 5 Stephan Bergmann 2003-08-05 08:30:36 UTC 
I'll add an OSL_ASSERT, but no real fix, as tools strings are
deprecated, anyway (see #i17875#).
Comment 6 Stephan Bergmann 2003-08-12 09:38:21 UTC 
.
Comment 7 Stephan Bergmann 2003-08-12 14:39:07 UTC 
.
Comment 8 Stephan Bergmann 2003-08-18 09:00:05 UTC 
.