Issue 16607 - 11rc: sal patches for locale + interlock
Summary: 11rc: sal patches for locale + interlock
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: fa
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks: 16413
  Show dependency tree
 
Reported: 2003-07-09 14:36 UTC by fa
Modified: 2004-02-15 07:31 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
cd to sal, patch -p0 < /path/to/patchfile Adds PORTS locale detection and preliminary interlock code for gcc 3.3 (38.17 KB, patch)
2003-07-09 14:39 UTC, fa 		no flags Details | Diff
unzip to sal/systools, implements OS X shared library for locale lookup (3.30 KB, application/octet-stream)
2003-07-09 14:41 UTC, fa 		no flags Details
cd sal, patch -p0 < /path/to/patchfile SUPERCEDES all previous sal.xxx.11rc patches, updates interlock code (36.65 KB, patch)
2003-07-09 16:08 UTC, fa 		no flags Details | Diff
contains only interlock asm pieces of 070903-2 patch (740 bytes, patch)
2003-07-14 19:19 UTC, fa 		no flags Details | Diff
contains all other non-interlock pieces of 070903-2 patch (35.93 KB, patch)
2003-07-14 19:20 UTC, fa 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description fa 2003-07-09 14:36:59 UTC 
These patches add in sal locale support for Mac OS X.  Also update interlock code for gcc 3.3 
(suggestions from Jim White), but I'd really like someone to look over this as I'm unsure about it.  
kevin?
Comment 1 fa 2003-07-09 14:39:53 UTC 
Created attachment 7500 [details]
cd to sal, patch -p0 < /path/to/patchfile   Adds PORTS locale detection and preliminary interlock code for gcc 3.3
Comment 2 fa 2003-07-09 14:41:28 UTC 
Created attachment 7501 [details]
unzip to sal/systools, implements OS X shared library for locale lookup
Comment 3 fa 2003-07-09 16:08:46 UTC 
Created attachment 7506 [details]
cd sal, patch -p0 < /path/to/patchfile  SUPERCEDES all previous sal.xxx.11rc patches, updates interlock code
Comment 4 khendricks 2003-07-10 15:41:32 UTC 
Hi Dan,

This patch looks fine but it is complicated enough I will apply it
to my PPC Linux sal from OOo 1.1rc and verify that it does not 
break anything for anyone else before approving it for commit.

Kevin
Comment 5 fa 2003-07-14 19:16:25 UTC 
I will break this patch into two parts: the interlock asm stuff and everything else.  I 
will commit the everything else (including sal locale changes + extra OS X locale 
dylib) but NOT commit the interlock stuff pending your test Kevin.

Dan
Comment 6 fa 2003-07-14 19:19:48 UTC 
Created attachment 7644 [details]
contains only interlock asm pieces of 070903-2 patch
Comment 7 fa 2003-07-14 19:20:55 UTC 
Created attachment 7645 [details]
contains all other non-interlock pieces of 070903-2 patch
Comment 8 khendricks 2003-07-14 19:30:14 UTC 
Hi Dan,

Please commit the whole thing.

I can handle the asm interlock stuff just fine for PPC Linux.

No worries.

Kevin
Comment 9 fa 2003-07-14 19:32:44 UTC 
Changes from sal.070903-2-locale.11rc.patch committed to cws_srx645_ooo11rc2.
Comment 10 fa 2003-07-14 19:34:15 UTC 
sal.070903-2-interlock.11rc.patch committed to cws_srx645_ooo11rc2
Comment 11 Martin Hollmichel 2004-02-15 07:28:38 UTC 
verfied in 1.1.0.
Comment 12 Martin Hollmichel 2004-02-15 07:31:48 UTC 
close issue