Issue 16425 - 11rc: soltools patch - checkdll -> NSModule, makedepend fstat() issue
Summary: 11rc: soltools patch - checkdll -> NSModule, makedepend fstat() issue
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: fa
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks: 16413
  Show dependency tree
 
Reported: 2003-07-03 20:49 UTC by fa
Modified: 2004-02-15 07:31 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
cd to soltools, patch -p0 < /path/to/patchfile Updates checkdll to use NSModule APIs, work around soltools fstat() wierdness (6.66 KB, patch)
2003-07-03 20:50 UTC, fa 		no flags Details | Diff
Correct variable types to prevent overflows (7.46 KB, patch)
2003-07-15 02:27 UTC, fa 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description fa 2003-07-03 20:49:12 UTC 
Update checkdll to use the NSModule APIs (NSAddImage(), etc) instead of CoreFoundation bundle 
APIs.  Also, work around some wierdness with fstat() and st.st_size returning 0 all the time.
Comment 1 fa 2003-07-03 20:50:12 UTC 
Created attachment 7393 [details]
cd to soltools, patch -p0 < /path/to/patchfile   Updates checkdll to use NSModule APIs, work around soltools fstat() wierdness
Comment 2 Martin Hollmichel 2003-07-04 07:55:45 UTC 
set target milestone
Comment 3 khendricks 2003-07-10 16:16:55 UTC 
Hi Dan,

SAince this touches non-MacOSX specific code (the fstat stuff), I will test
it on my PPC Linux build to make sure all is okay (with your change, you are
 assigning a 64 bit quantity to a 32 bit type here?).

Kevin
Comment 4 sander_traveling 2003-07-15 00:34:14 UTC 
the 64 bit vs 32 bit issue was covered in porting@ - both freebsd and
macosx (*bsd in general - and possibly os-s like solaris with some
defines turned on) can access fiels upto 2^64, while memory may remain
32bit meaning that if there ever is a case where a file taht doesn't
fit in memory would be loaded, mkdepend should just error out instead
of mangling things in various ways.
Comment 5 fa 2003-07-15 02:27:24 UTC 
Created attachment 7662 [details]
Correct variable types to prevent overflows
Comment 6 khendricks 2003-07-15 02:43:02 UTC 
Hi Dan,

I reviewed it and I think you have handled all of Joerg's issues since you now use a 
signed type to hold the rerutn value from read and you even test for truncation.

This looks good to me so approved.

Kevin
Comment 7 sander_traveling 2003-07-15 02:47:00 UTC 
same here - it looks ok
Comment 8 fa 2003-07-15 03:11:13 UTC 
committed to cws_srx645_ooo11rc2
Comment 9 Martin Hollmichel 2004-02-15 07:28:37 UTC 
verfied in 1.1.0.
Comment 10 Martin Hollmichel 2004-02-15 07:31:47 UTC 
close issue