Issue 16415 - 11rc: icu changes for DLLPOST and OS X
Summary: 11rc: icu changes for DLLPOST and OS X
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: fa
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks: 16413
  Show dependency tree
 
Reported: 2003-07-03 17:51 UTC by fa
Modified: 2004-02-15 07:31 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
place this patch in icu/ (replacing previous) (31.80 KB, patch)
2003-07-03 17:52 UTC, fa 		no flags Details | Diff
cd to icu, patch -p0 < /path/to/patchfile Updates makefile for DLLPOST (1.56 KB, patch)
2003-07-03 17:53 UTC, fa 		no flags Details | Diff
place file in icu/ replacing previous. Changes install loc of libraries to @executable_path (32.94 KB, patch)
2003-07-11 15:57 UTC, fa 		no flags Details | Diff
add back some missing pieces from original ooo11rc2 version (34.14 KB, patch)
2003-07-15 02:42 UTC, fa 		no flags Details | Diff
link against the icuuc library to prevent link error (34.81 KB, patch)
2003-07-15 02:51 UTC, fa 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description fa 2003-07-03 17:51:26 UTC 
Need to change hardcoded .so -> $(DLLPOST), and re-order the library name for OS X.
Comment 1 fa 2003-07-03 17:52:27 UTC 
Created attachment 7380 [details]
place this patch in icu/ (replacing previous)
Comment 2 fa 2003-07-03 17:53:23 UTC 
Created attachment 7381 [details]
cd to icu, patch -p0 < /path/to/patchfile   Updates makefile for DLLPOST
Comment 3 Martin Hollmichel 2003-07-04 07:54:23 UTC 
set target milestone
Comment 4 khendricks 2003-07-10 16:07:54 UTC 
Hi,

Both patches approved for commit to 1.1 once it re-opens
since MacOSX specific  and  DLLPOST is obviously correct.

Kevin
Comment 5 fa 2003-07-11 15:57:34 UTC 
Created attachment 7587 [details]
place file in icu/ replacing previous.  Changes install loc of libraries to @executable_path
Comment 6 khendricks 2003-07-11 16:10:16 UTC 
Hi,

Latest icu-2.2.patch approved for commit to OOo 1.1

Dan I have already reviewed and approved most of the patches you have submitted in 
this issue.  They are very safe.

Perhaps we should ask martin and Sander if we can go ahead and commit them to 
cws_srx645_ooo11rc2?

That way the patch count stays smaller and we are more likely to get others to help
if they can build the tree with only a few patches.

What do you think?

Kevin
Comment 7 fa 2003-07-14 17:59:21 UTC 
committed to cws_srx645_ooo11rc
Comment 8 fa 2003-07-15 02:42:34 UTC 
Created attachment 7663 [details]
add back some missing pieces from original ooo11rc2 version
Comment 9 fa 2003-07-15 02:51:44 UTC 
Created attachment 7664 [details]
link against the icuuc library to prevent link error
Comment 10 Martin Hollmichel 2004-02-15 07:28:09 UTC 
verfied in 1.1.0.
Comment 11 Martin Hollmichel 2004-02-15 07:31:17 UTC 
close issue