Issue 16370 - Warning that indicates coding error
Summary: Warning that indicates coding error
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: PC All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: Oliver Specht
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-03 04:39 UTC by foskey
Modified: 2013-08-07 14:41 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch that removes warning. (978 bytes, patch)
2003-07-03 14:25 UTC, foskey 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description foskey 2003-07-03 04:39:32 UTC 
The following two errors indicate a crash causing coding error that needs to be 
addressed.

/data3/office/sw/source/ui/misc/docfnote.cxx:159: warning: casting 
`SfxItemSet*´ to `SfxItemSet&´ does not dereference pointer
/data3/office/sw/source/ui/misc/docfnote.cxx:162: warning: casting 
`SfxItemSet*´ to `SfxItemSet&´ does not dereference pointer
Comment 1 h.ilter 2003-07-03 12:18:00 UTC 
Reassigned to OS
Comment 2 foskey 2003-07-03 14:25:15 UTC 
Created attachment 7373 [details]
patch that removes warning.
Comment 3 foskey 2003-07-03 14:26:13 UTC 
This should go earlier,  the code is just wrong, see patch.
Comment 4 Oliver Specht 2003-07-03 14:59:32 UTC 
Changing the code as you proposed would remove the warning but doesn't
really improve the code. It's still a hack. 
The SfxTabPage::FillItemSet() method wants the reference of an object
not of a dereferenced NULL pointer. It works because the two derivated
classes don't access the SfxItemSet&.

I don't agree to your target change. There's no need to hurry.
Comment 5 Oliver Specht 2003-09-12 13:16:04 UTC 
Fixed in cws os20
Comment 6 Oliver Specht 2003-09-19 10:18:21 UTC 
Set to verified, no QA check possible.
Comment 7 Oliver Specht 2003-10-06 11:47:48 UTC 
.