Issue 16323 - Unecessary link libraries in crashrep
Summary: Unecessary link libraries in crashrep
Status: CLOSED NOT_AN_OOO_ISSUE
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: hennes.rohling
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-02 12:08 UTC by chris
Modified: 2003-07-03 10:30 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Simplify crashrep linking (1.17 KB, patch)
2003-07-02 12:09 UTC, chris 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description chris 2003-07-02 12:08:54 UTC 
The libraries listed on the link command line are not necessary to build
crashrep on my system - all I need are those listed by pkg-config --libs
gtk+-2.0.  Can the makefile be changed to not pull in these libraries where it
is not necessary?

My guess is that the libs are either needed on non-gcc systems or statically
linked gtk setups.  But I can't test the static linking because of issue 15843.

I attach a patch that removes the libs for GCC systems and also simplifies the
linker flags by making use of the $(STATIC) and $(DYNAMIC) macros.

Tested on Linux, Debian unstable.
Comment 1 chris 2003-07-02 12:09:34 UTC 
Created attachment 7330 [details]
Simplify crashrep linking
Comment 2 Martin Hollmichel 2003-07-03 09:13:36 UTC 
set target and prio.
Comment 3 hennes.rohling 2003-07-03 10:28:14 UTC 
At least on my ReadHat 7.2 the patch does not work because the
additional library references are mandatory. This applies to static
and dynamic linking.
It's not a defect if on some machine the link line can be shorter.
Comment 4 hennes.rohling 2003-07-03 10:30:19 UTC 
Using $(DYNAMIC) and $(STATIC) though is a good idea. Will befixed
with issue 15843.