Issue 16191 - build failure with kernel 2.2.x in module desktop
Summary: build failure with kernel 2.2.x in module desktop
Status: CLOSED DUPLICATE of issue 16207
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: Other Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: thorsten.martens
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-28 16:23 UTC by holgerth
Modified: 2004-03-18 15:18 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
file_image_unx_kernel_2_2_x_build.patch (1.24 KB, patch)
2003-06-28 16:25 UTC, holgerth 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description holgerth 2003-06-28 16:23:26 UTC 
Kernel 2.2.x does not support read ahead with MADV_WILLNEED: 
 
A patch follows also eliminating the gotos in the code 
 
Making: ../../unxlngi4.pro/obj/file_image_unx.obj 
/u/ooo-gcc-3.0.4/bin/gcc -fmessage-length=0 -c -I.  -I. -I../inc -I../../inc -I../../unx/inc 
-I../../unxlngi4.pro/inc -I. 
-I/mnt/ooo/cws_srx645_ooo11rc/solver/645/unxlngi4.pro/inc/dont_use_stl 
-I/mnt/ooo/cws_srx645_ooo11rc/solver/645/unxlngi4.pro/inc/external 
-I/mnt/ooo/cws_srx645_ooo11rc/solver/645/unxlngi4.pro/inc 
-I/mnt/ooo/cws_srx645_ooo11rc/solenv/unxlngi4/inc 
-I/mnt/ooo/cws_srx645_ooo11rc/solenv/inc -I/mnt/ooo/cws_srx645_ooo11rc/res 
-I/mnt/ooo/cws_srx645_ooo11rc/solver/645/unxlngi4.pro/inc/dont_use_stl 
-I/mnt/ooo/cws_srx645_ooo11rc/solenv/inc/Xp31 -I/u/j2sdk1.4.1_02/include 
-I/u/j2sdk1.4.1_02/include/linux -I/u/j2sdk1.4.1_02/include/native_threads/include 
-I/usr/X11R6/include     -I. -I../../res -I. -O1   -pipe -mcpu=pentiumpro   -DLINUX -DUNX 
-DVCL -DGCC -DC300 -DINTEL -DCVER=C300 -D_USE_NAMESPACE -DGLIBC=2 -DX86 
-D_PTHREADS -D_REENTRANT -DNEW_SOLAR -D_USE_NAMESPACE=1 
-DSTLPORT_VERSION=400 -D__DMAKE -DUNIX -DCPPU_ENV=gcc3 -DSUPD=645 
-DBUILD=8639 -DPRODUCT -DNDEBUG -DPRODUCT_FULL -DOSL_DEBUG_LEVEL=0 
-DOPTIMIZE -DEXCEPTIONS_OFF -DCUI -DSOLAR_JAVA -DSRX645  -DMULTITHREAD   -o 
../../unxlngi4.pro/obj/file_image_unx.o file_image_unx.c 
file_image_unx.c:70:1: warning: "__USE_BSD" redefined 
/usr/include/features.h:215:1: warning: this is the location of the previous definition 
file_image_unx.c: In function `file_image_pagein': 
file_image_unx.c:134: `MADV_WILLNEED' undeclared (first use in this function) 
file_image_unx.c:134: (Each undeclared identifier is reported only once 
file_image_unx.c:134: for each function it appears in.) 
dmake:  Error code 1, while making '../../unxlngi4.pro/obj/file_image_unx.obj' 
---* TG_SLO.MK *--- 
 
ERROR: Error 65280 occurred while making 
/mnt/ooo/cws_srx645_ooo11rc/desktop/source/pagein 
e/app 
/mnt/ooo/cws_srx645_ooo11rc/desktop/scripts 
/mnt/ooo/cws_srx645_ooo11rc/desktop/source/splash 
/mnt/ooo/cws_srx645_ooo11rc/desktop/source/so_comp 
/mnt/ooo/cws_srx645_ooo11rc/desktop/source/pagein 
dmake:  Error code 1, while making 'build_all' 
---* TG_SLO.MK *---
Comment 1 holgerth 2003-06-28 16:25:00 UTC 
Created attachment 7207 [details]
file_image_unx_kernel_2_2_x_build.patch
Comment 2 khirano 2003-06-30 04:46:46 UTC 
Is this the same as:
http://www.openoffice.org/issues/show_bug.cgi?id=16207
?
Comment 3 holgerth 2003-06-30 05:19:20 UTC 
Yes, it's the same. Marked it as duplicate of your issue.

Your solution redefining MADV_WILLNEED if undefined seems better;
because pagein could be compiled on a glibc 2.1.3 system and would
work as intended on a glibc 2.2 system.

If causing trouble, glibc-version could be determined at runtime
and madvice() be called if it's 2.2 or higher afterwards.

*** This issue has been marked as a duplicate of 16207 ***
Comment 4 thorsten.martens 2004-03-18 15:18:57 UTC 
.