Issue 16084 - W32 build with .NET fails in python
Summary: W32 build with .NET fails in python
Status: CLOSED FIXED
Alias: None
Product: udk
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: PC Windows 2000
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: quetschke
QA Contact: issues@udk
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-25 20:43 UTC by quetschke
Modified: 2003-07-31 09:22 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
patch for msdev6/ cygwin tcsh build (1.60 KB, patch)
2003-07-01 21:34 UTC, joergbudi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2003-06-25 20:43:05 UTC
The build breaks because

Python-2.2.2/Modules/_hotspot.c  needs largeint.h
  and
Python-2.2.2/PC/python_nt.rc     needs ver.h

These files are in the standard include directory from MSVC6, but microsoft
obviously skipped them for .NET .

After copying the files from VC6 to some solver/../inc the module builds.

Ideas?

(Yes, at least for ver.h. patch python_nt.rc to use winver.h)
Comment 1 quetschke 2003-06-25 20:44:20 UTC
Hmm, we should get this solved until 1.1, lets try 1.1RC

Comment 2 joergbudi 2003-06-25 21:27:40 UTC
Hi,

I don't yet have a .net compiler yet, the .net port was actually done
by obo@openoffice.org, maybe he can say something about this.

( Note, that some .NET port changes are not yet part of the ooo11rc, I
don't know, whether this is by desired or not).

Bye, Joerg
Comment 3 oliver.bolte 2003-06-30 12:54:08 UTC
Do you really use Python-2.2.2.patch rev. 1.4 ? In this patch the fix
is already included.

Oliver.
Comment 4 quetschke 2003-06-30 13:18:39 UTC
No, at the moment cws_srx644_ooo11rc still uses rev1.1.

vq->mh: Can we merge rev 1.4?
Comment 5 oliver.bolte 2003-06-30 14:32:22 UTC
Additionally needed files: convert.sh (rev. 1.1), convert.bat (rev 1.1),
makfile.mk (rev. 1.4) these are necessary to prevent the damage of
UNIX builds.

Oliver.
Comment 6 oliver.bolte 2003-06-30 14:35:44 UTC
.
Comment 7 quetschke 2003-06-30 15:34:12 UTC
Sorry to reopen, but now we're in merging hell!

If we use rev 1.4 of makefile.mk, the first patch to it on RC
(1.3 -> 1.3.2.1) is already merged, but the second (1.3.2.1 -> 1.3.2.2)
is not and will conflict.

vq->pjanik: Can you please check out (from HEAD):

makefile.mk         rev. 1.4
Python-2.2.2.patch  rev. 1.4
convert.sh          rev. 1.1
convert.bat         rev. 1.1

and test if the parallel build works with this revisions from HEAD.
Comment 8 quetschke 2003-06-30 15:48:19 UTC
Reassigned to Pavel, please test!
Comment 9 pavel 2003-06-30 21:50:41 UTC
It works on GNU/Linux system - both python and pyuno compiled.

Can we close it Joerg?

I did not track this issue and reading about .NET is not my preferred
reading for the night :-))
Comment 10 quetschke 2003-06-30 22:00:26 UTC
Sorry Pavel, did you read the previous post in this issue?

> vq->pjanik: Can you please check out (from HEAD):
>
> makefile.mk         rev. 1.4
> Python-2.2.2.patch  rev. 1.4
> convert.sh          rev. 1.1
> convert.bat         rev. 1.1
>
> and test if the parallel build works with this revisions from HEAD.

Sorry for the .NET stuff. OK to use the HEAD versions?

  Volker
Comment 11 pavel 2003-06-30 22:11:45 UTC
No, as I said, I have not read it completely - I will look at it
tomorrow because I have yet to finished non-SMP build of current CVS.
Comment 12 joergbudi 2003-07-01 21:32:12 UTC
In order to get this build correctly in

msdev6,cygwin-tcsh, MAXPROCESS=4

I need the following patch to makefile.mk . 

With 

msdev6,4nt shell, I can't build, I get something like

[z:\oo1.1beta2\python]dmake
cc: Command not found.
/usr/bin/sed: -e expression #1, char 17: Unterminated address regex
dmake:  Error code 1, while making 'Shell escape'


without the faintest idea, where this comes from.
Comment 13 joergbudi 2003-07-01 21:34:19 UTC
Created attachment 7316 [details]
patch for msdev6/ cygwin tcsh build
Comment 14 quetschke 2003-07-01 22:06:32 UTC
Hi Joerg,

> In order to get this build correctly in
>
> msdev6,cygwin-tcsh, MAXPROCESS=4
>
> I need the following patch to makefile.mk . 
Looks reasonable.

> With msdev6,4nt shell, I can't build, I get something like
> ...
> cc: Command not found.
> /usr/bin/sed: -e expression #1, char 17: Unterminated address regex
> dmake:  Error code 1, while making 'Shell escape'
>
> without the faintest idea, where this comes from.

Five minutes ago I run into a similar problem. ;-) Your current
dmake is the cygwin version.
You have to delete dmake/dmake.exe and solenv/wntmsci9/bin/dmake.exe,
clear the dmake directory and build a new dmake with winenv.bat.

Another possible problem: When you generate your winenv.bat, you get
also a winenv.set !!!! This can not be used to build with W32-tcsh,
you have to create a correct winenv.set with
  $ configure --with-use-shell=tcsh ...

Volker
Comment 15 joergbudi 2003-07-01 22:31:36 UTC
BWMHOTT (Banging with my head on the table)

:)

So, I think with the patch, everything should be fine.

Thx, Joerg
Comment 16 quetschke 2003-07-02 10:54:11 UTC
Will you commit the changes? (All four files?)
Comment 17 joergbudi 2003-07-03 06:12:00 UTC
Sorry, didn't mention, that I don't have write access in external
(just udk, dba, and installation). So will you (vq) commit ?
Comment 18 quetschke 2003-07-04 16:14:29 UTC
I committed the patch to cws_srx645_ooo11rc2.

The cws_srx645_ooo11rc branch still doesn't contain the
changes and will not build with .NET. Just use the rc2 version
instead.
Comment 19 quetschke 2003-07-25 18:34:39 UTC
Resolving issue, patch is in rc2 and rc3.
Comment 20 joergbudi 2003-07-31 09:22:15 UTC
closing fixed issues for 1.1. release.