Issue 16081 - Add Czech and Slovak to locales.tab of Gnome and CDE
Summary: Add Czech and Slovak to locales.tab of Gnome and CDE
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: khendricks
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-25 19:16 UTC by pavel
Modified: 2003-08-11 20:00 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2003-06-25 19:16:51 UTC
Hi,

I'd like to add Czech and Slovak (42 and 43) to

sysui/oounix/office/cde/locales.tab
sysui/oounix/office/gnome/locales.tab

Patches (inline, because they are small):

Gnome:

--- locales.tab.~1.2.~	2002-08-28 14:10:08.000000000 +0200
+++ locales.tab	2003-06-25 20:16:00.000000000 +0200
@@ -7,6 +7,8 @@
 34 = es
 37 = ca
 39 = it
+42 = cs
+43 = sk
 45 = da
 46 = sv
 48 = pl

CDE:

--- locales.tab.~1.2.~	2002-08-28 14:07:47.000000000 +0200
+++ locales.tab	2003-06-25 20:18:09.000000000 +0200
@@ -8,6 +8,8 @@
 locales+=$(assign locale_35 = fi fi.UTF-8)
 locales+=$(assign locale_37 = ca)
 locales+=$(assign locale_39 = it it.UTF-8)
+locales+=$(assign locale_42 = cs cs.UTF-8)
+locales+=$(assign locale_43 = sk sk.UTF-8)
 locales+=$(assign locale_45 = da da.UTF-8)
 locales+=$(assign locale_46 = sv sv.UTF-8)
 locales+=$(assign locale_48 = pl pl.UTF-8)

OK to commit?
Comment 1 christof.pintaske 2003-06-26 11:28:23 UTC
cp->obr: just have a look
Comment 2 nospam4obr 2003-06-26 12:04:40 UTC
Hi Pavel,

AFAIK the oounix/gnome tree is no longer build. I left its removal up
to Kevin, but was maybe not clear enough on this. To get your strings
into the Gnome 1.4 desktop integration files, you need to manually add
them into the desktop/gnome/legacy files.

The patch for CDE looks o.k.. I assume that lngconv does now have
textencoding fallback for cs and sk build in and that the lng files
contain the corresponding text entries ?!
Comment 3 pavel 2003-06-26 13:16:45 UTC
OK, all lng files in cde contains strings for both 42 and 43 so I will
commit my change to cde.

Kevin, could you please review oounix/office/gnome existence?
Comment 4 pavel 2003-06-26 13:24:28 UTC
sysui/oounix/office/gnome/locales.tab was a leftover from previous
versions, gnome/legacy contains Czech and Slovak translation in
printeradmin.desktop only as other languages.
Comment 5 nospam4obr 2003-06-27 08:06:08 UTC
Doesn't look as if I had to do anything on this ;-)
Comment 6 pavel 2003-06-27 20:14:33 UTC
Kevin, could you please review oounix/office/gnome existence?
Comment 7 khendricks 2003-06-27 20:47:02 UTC
Hi, 
 
I am not sure what you mean by "review its existence?" 
 
AFAIK, sysui/desktop/gnome is where the OOo 1.1 rc builds 
use. 
 
You can see this in sysui/prj/build.lst 
 
su      sysui\desktop\gnome                     nmake   -       u       su_gnome NULL 
su      sysui\desktop\gnome\legacy      nmake   -       u       su_lgnome NULL 
 
So are you asking me to delete the old sysui/oounix/office/gnome? 
 
Or is there some other change you need? 
 
Thanks, 
 
Kevin 
 
Comment 8 pavel 2003-06-27 21:52:06 UTC
Yes, I think we do not need sysui/oounix/office/gnome.
Comment 9 pavel 2003-07-04 08:37:02 UTC
Kevin, will you remove it orwe could close this issue as WONTFIX?
Comment 10 khendricks 2003-07-04 12:40:21 UTC
Hi, 
 
Yes, I will remove it in time to help reduce the size of OOo 1.1 Final source tarball. 
 
So please just leave this issue as open and I will get to it before final. 
 
Thanks, 
 
Kevin 
 
Comment 11 pavel 2003-08-06 11:19:24 UTC
Isn't it the right time now, Kevin?
Comment 12 khendricks 2003-08-11 17:20:02 UTC
Hi, 
 
I did a cvs remove on sysui/oounix/office/gnome and its contents 
just now on rc3 so I am closing this as fixed. 
 
Thanks, 
 
Kevin 
 
Comment 13 khendricks 2003-08-11 17:25:34 UTC
closing it 
Comment 14 pavel 2003-08-11 20:00:57 UTC
Thank you, Kevin.