Issue 15629 - Don't include <asm/sigcontext.h> for sparc linux
Summary: Don't include <asm/sigcontext.h> for sparc linux
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC2
Hardware: Other Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: sander_traveling
QA Contact: issues@porting
URL:
Keywords:
: 17324 (view as issue list)
Depends on: 8593
Blocks: 17420
  Show dependency tree
 
Reported: 2003-06-15 12:04 UTC by sparcmoz
Modified: 2003-12-28 14:23 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch to dont include <asm/sigcontext.h> (597 bytes, patch)
2003-06-15 12:05 UTC, sparcmoz 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description sparcmoz 2003-06-15 12:04:22 UTC 
This is explained in issue 8593: "3) Don't include <asm/sigcontext.h>. (i)
because user code is not supposed to do so explicitly. (ii) the actual
definition is bound to be grabbed from <signal.h> or derivatives."

From reading issue 8593 it appears this should be done for all platforms? But my
patch is just for sparc linux. (in sparc linux there are two versions of
sigcontext.h and OO tries to include both of them.)
Comment 1 sparcmoz 2003-06-15 12:05:47 UTC 
Created attachment 6891 [details]
patch to dont include <asm/sigcontext.h>
Comment 2 sparcmoz 2003-07-17 12:30:53 UTC 
This should be fixed when issue #8593 is fixed but meanwhile this
patch is needed to build on sparc linux
Comment 3 rene 2003-07-26 09:34:53 UTC 
*** Issue 17324 has been marked as a duplicate of this issue. ***
Comment 4 sparcmoz 2003-07-26 09:56:49 UTC 
This is confirmed now since Rene has reported the same problem for sparc 
linux. It would be appreciated if someone could commit this patch for me, it 
is only for sparc linux.
Comment 5 stx123 2003-07-29 13:46:59 UTC 
Sander, could have a look at the patch. Thanks
Comment 6 sander_traveling 2003-07-29 19:28:35 UTC 
looks fine - and no impact onother platforms
Comment 7 sparcmoz 2003-07-29 22:24:09 UTC 
Please note i can not commit patches so i would appreciate someone
commit this patch for me, thanks.
Comment 8 jens-heiner.rechtien 2003-07-30 17:05:15 UTC 
Fixed on ooo11rc3.
Comment 9 pavel 2003-12-28 14:23:30 UTC 
Closing.