The -g is added by configure by option.  The issue here is that it
keeps coming back because SO developers must change their internal
software.

mh->waratah: that what is this issue for.

enclose additional crashdump compilerflags in ENABLE_CRASHDUMP

CFLAGSCRASHDUMP now set in "wnt.mk", "unxlngi5.mk" and "unxsols4.mk".
the defined switches get inserted in "settings.mk" if the environment
variable ENABLE_CRASHDUMP is set. please do the according cvhanges in
"config_office".

Created attachment 7189 [details]
Patch for configure.in and set_soenv.in

Untested patch, but it should do.

Added approval_pending flag

it doesn't work, I assume previous version (GTK test) killed me:

line 4891: syntax error near unexpected token `GTK,`
line 4891: `      PKG_CHECK_MODULES( GTK, $pkg_modules )` 

Please use autoreconf not autoconf.  I will check whether I should
commit my aclocal to remove this problem for others.

I am not sure whether I like removing the existing flagg to add -g. 
There may well be other platforms that do not have crashdump that want
the -g option to stay in place.

This patch must be held up until all patches are inplace in the
solenv/inc directory.

Created attachment 7276 [details]
Patch to set ENABLE_CRASHDUMP, no other functionality changed

Created attachment 7277 [details]
Typo in previous patch, use this.

Created attachment 7278 [details]
ENABLE_CRASHDUMP for unxlngi4.mk

unxlgni4.mk change approved

unxlgni4.mk change committed

If I'm not wrong, the crashreporter needs a build with symbols. That
means that all systems, except WNT, have to call configure with
 --enable-symbols to get a working crashreporter.

This also means that without my c_o2.diff there is no way (without
tweaking) to get the WNT version been build with symbols, because the
--enable-symbols switch doesn't enable symbols for WNT.

Setting the ENABLE_CRASHDUMP variable enables the build with symbols on
wnt, unxlngi4, unxlngi5 and unxsols4.mk.

I make this prio 2: Basic functionality is not working correctly.

(Maybe I'm wrong, but I consider the crashrep very important, and a
must have for the RC)

I said prio 2!

mh->vq: configure patch approved.

Committed to RC

This patch is not merged to rc2!

merged to RC2

If you disable crashrep build, do you still need to have GTK
installed? If so, it is a bug.

Created attachment 7480 [details]
Patch for configure.in

The c_o3.diff patch changes the ENABLE_CRASHDUMP from "yes" to "TRUE"
as described in 16528.

Will commit soon to RC2

Committed c_o3.diff to RC2

I'd like to close this issue, but before we can do so, some
documentation of the ENABLE_CRASHDUMP variable would be usefull!

Is there a place for such documentation?

The documentation should also mention that --enable-crashdump
enables the build with symbols for WNT, Solaris and unxlngi4 and
unxlngi5 and not for other Systems.

The "settings" could be a bit more consistent. Better would be to have
also a --enable-symbols switch with an ENABLE_SYMBOLS variable. And in
the <OS_specific>.mk set CFLAGSENABLESYMBOLS instead of
CFLAGSCRASHDUMP to the correct compiler switch.

The configure would then implicitly set --enable-symbols when called
with --enable-crashdump.

And settings.mk would check for ENABLE_SYMBOLS instead of
ENABLE_CRASHDUMP != "".

This would also make sense for systems where no crashrep is available.

vq->mh: Just assign this issue back to me if the last --enable-symbols
part sounds reasonable, I will create a patch.
(This obsoletes issue 12442)

mh->vq: sounds good

I'm starting a build with the following two patches applied.

vq->waratah: I removed your ENVCFLAGS="-g" hack, if you want to
eanable a build with symbols, make sure you have a section like:

# flags to enable build with symbols; required for crashdump feature
CFLAGSENABLESYMBOLS=-g

in your unx*.mk.

Created attachment 7596 [details]
Patch for files in solenv/inc/

Created attachment 7597 [details]
Patch for configure.in and set_soenv.in

Patches work for me in tinderbox build.
OK for cws...rc2?

The following patches are the reworked version after the last changes
that went to configure.

It removes the ENVCFLAGS hack and moves the symbols switch to
the corresponding system makefiles.

We have at least three different compilers for the "core" builds
(gcc, MSVC and Solaris Forte), for two of them -g or -g1 is the
wrong switch, so this is the better approach.

Ken, please approve.

Mac and Freebsd have to change there unx*.mk files, but the changes
should be similar to unxlngi5.mk

Created attachment 8018 [details]
Patch for config_office/

Created attachment 8019 [details]
Patch for solenv/inc/

Looks reasonable to me.  Appoved in concept.

Hi Ken,

> Looks reasonable to me.  Appoved in concept.

does that mean: "Ok, commit it" or "Wait, I'll change it and commit it
later"?

Volker

OK for you to commit.

Take back ownership.

Committed to cws...rc3

Small summary:
Rework of the --enable-crashdump / --enable-symbols mechanism.

--enable-crashdump now implicitly activates --enable-symbols.

At the moment --enable-symbols enables the build with symbols for WNT,
Solaris, unxlngi4 and unxlngi5.

To enable a build with symbols (and get a usable crashreporter) when
your OS is not in the list above, make sure you use/supply a patch
with a section like:

# flags to enable build with symbols; required for crashdump feature
CFLAGSENABLESYMBOLS=-g

in your solenv/inc/<OS_specific>.mk.

The --enable-symbols=SMALL switch is also supported, when you use gcc
in your port consider using:

# flags to enable build with symbols; required for crashdump feature
.IF "$(ENABLE_SYMBOLS)"=="SMALL"
CFLAGSENABLESYMBOLS=-g1
.ELSE
CFLAGSENABLESYMBOLS=-g
.ENDIF

The CFLAGSCRASHDUMP variable is obsolete now.

verified

close issue.