Issue 14374 - English date in Confirm File Replacement dialog in Czech and Slovak version
Summary: English date in Confirm File Replacement dialog in Czech and Slovak version
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: pavel
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-12 16:53 UTC by pavel
Modified: 2003-06-20 11:40 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Screenshot of Czech setup (78.41 KB, image/png)
2003-05-12 16:54 UTC, pavel 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2003-05-12 16:53:25 UTC 
Hi Pavel (no, I'm no schisofrenic),

there is an English date in the Czech version of 1.1 Beta 2. Probably i18n bug.
See attached screenshot.
Comment 1 pavel 2003-05-12 16:54:19 UTC 
Created attachment 6147 [details]
Screenshot of Czech setup
Comment 2 pavel 2003-05-13 08:25:25 UTC 
The code is in setup2. Is it also in German version? Can you confirm? 
Or is this a problem in Czech version only?
Comment 3 Olaf Felka 2003-05-13 09:31:42 UTC 
I can't tell you: I only have an english beta2.
Comment 4 pavel 2003-05-13 13:49:38 UTC 
I have tried German version and it is in German there. So this is a
problem with Czech version.

I will solve it myself.
Comment 5 pavel 2003-05-13 21:51:10 UTC 
This seems to be a problem in tools/source/intntl/intntab.cxx:

Czech is commented there:

pavel@pavel:~/Tmp/ooo_11beta2_src/tools> grep -B 2
ImplUpdateFormatCzech source/
intntl/intntab.cxx
// -----------------------------------------------------------------------
/*
static void ImplUpdateFormatCzech( FormatTable* pTable )
--
/*
                case LANGUAGE_CZECH:
                        ImplUpdateFormatCzech( pTable );

Slovak is not there at all.

Please add correct definitions for both languages.

Why we do have this in addition to cs_CZ.xml and sk_SK.xml?

Eike, could you please help us with this?

I upped the priority for this.
Comment 6 ooo 2003-05-14 12:42:38 UTC 
Pavel,

tools/source/intntl/intntab.cxx is old legacy code and class
International is deprecated and shouldn't be used anymore, except by
some tools of the build environment. This is surely something for the
installation project to fix, I therefore reassign this issue to Dirk.

@Dirk:
In setup2/source/ui/dialog/overdlg.cxx
OverwriteFileDialog::SetExistFile() and SetSourceFile()} still use
class International. A short grep also revealed other places were
class International is used, mainly to format date/time values for
logging purposes.

Please eliminate usage of class International and use
LocaleDataWrapper::getDate(), getTime() instead,
unotools/localedatawrapper.hxx
Comment 7 dirk.voelzke 2003-05-15 15:07:21 UTC 
fixed in SRX644 setup09.
Comment 8 dirk.voelzke 2003-05-21 09:17:34 UTC 
Please verify.
Comment 9 Olaf Felka 2003-05-21 15:28:45 UTC 
Looks good for me in cws setup09.
Comment 10 Olaf Felka 2003-05-21 15:29:18 UTC 
Verified.
Comment 11 pavel 2003-05-31 10:25:32 UTC 
I do not think ve verified that it is corrected in Czech version (see
the Summary) so I will reopen this to check whet setup09 is merged.
Comment 12 pavel 2003-05-31 10:27:21 UTC 
I will verify it is correct.
Comment 13 Olaf Felka 2003-06-02 10:24:04 UTC 
Hi Pavel,
please verify and close: It should be fixed for RC.
Comment 14 Olaf Felka 2003-06-02 10:25:40 UTC 
Fied for RC
Comment 15 pavel 2003-06-20 11:39:00 UTC 
Yes, it is fixed in RC.

Thank!
Comment 16 pavel 2003-06-20 11:40:50 UTC 
-