Issue 14200 - DDE-link crashes wordprocessor
Summary: DDE-link crashes wordprocessor
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 1.1
Hardware: PC All
: P1 (highest) Trivial (vote)
Target Milestone: ---
Assignee: eric.savary
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-07 11:44 UTC by Rainer Bielefeld
Modified: 2013-08-07 14:44 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Rainer Bielefeld 2003-05-07 11:44:29 UTC 
Steps to reproduce:
1. create a calc spreadsheet with 2 cells containing "Information1" (a1) and 
   "Information2" (B1)
2. Save calc-file
3. create writer-file
4. goto calc-file
5. mark A1-B1
6. <Ctrl-C>
7. goto wordprocessor-file
8. Insert contents / DDE-Link
   a Table will be created with 2 cells "Information1" and "Information2"
   You can test DDE: changes in the calc-sheet-Cells ("Information1" to 
   "Information1a" will be shown in the writer-document, too
9. save and close both files
10. Open writer- file
    A message-window will appear with question "actualize ..."
11. Press "Yes"
    expected: writer-rile will open with actual table-contents from calc-file
    actual: crash

Everything works fine, if you open the spreadsheet before the writer-file, but
that can be no solution. I am used from other WINDOWS- applications, that they
open the DDE- source-file "internally" and insert the actual information from
the source to the writer-document.
Comment 1 Joost Andrae 2003-05-22 17:43:37 UTC 
JA->OS: Reproducible on my XP box. Look at crash report ID rqzv46. SBA
mentioned this as probably fixed within CWS os10 ? Retargetted to
ooo1.1 and reassigned to you.
Comment 2 Oliver Specht 2003-05-23 08:24:48 UTC 
OS->TL: In svx/source/svxlink/linkmgr.cxx line 412/413 is the
following code: 
const SfxPoolItem* pRet = SfxViewFrame::Current()->GetDispatcher()->
                Execute( SID_OPENDOC, SFX_CALLMODE_SYNCHRON, &aName,
&aMinimized, &aReferer, &aTarget, 0L );
that tries to access a current view frame that's not available as long
as no document is open. 
This has to be exchanged by: 

SfxAllItemSet aArgs( SFX_APP()->GetPool() );
SfxRequest aRequest( SID_OPENDIC, SFX_CALLMODE_SYNCHRON, aArgs );
SFX_APP()->ExecuteSlot( aRequest );
Comment 3 Oliver Specht 2003-05-23 09:18:34 UTC 
OS->TL: Sorry, I forgot some parts:
SfxAllItemSet aArgs( SFX_APP()->GetPool() );
aArgs.Put(aReferer);
aArgs.Put(aTarget);
aArgs.Put(aMinimized);
aArgs.Put(aName);
SfxRequest aRequest( SID_OPENDOC, SFX_CALLMODE_SYNCHRON, aArgs );
			SFX_APP()->ExecuteSlot( aRequest );
const SfxPoolItem*	pRet = aRequest.GetReturnValue();
Comment 4 Joost Andrae 2003-05-23 10:36:53 UTC 
JA: changed status to new
Comment 5 thomas.lange 2003-05-26 09:13:28 UTC 
Files changed:
 svx/*/linkmgr.cxx  1.15.234.1

Fixed in CWS sw015.
Comment 6 Rainer Bielefeld 2003-05-26 13:05:16 UTC 
One question still:

before the fix, for each DDE-Link in the text document (all from the
same calc-document) an additional copy of the calc-documet was opened
to actualize the contents. That seems to be no good idea.

Is that beviour fixed, too?

If not, another issue should be opened for that.

Rainer
Comment 7 thomas.lange 2003-05-28 15:34:33 UTC 
.
Comment 8 thomas.lange 2003-05-28 15:36:07 UTC 
TL->ES: Please check.
Comment 9 thomas.lange 2003-05-28 15:36:37 UTC 
.
Comment 10 Rainer Bielefeld 2003-06-04 07:44:24 UTC 
Hi,
I tried 1.1 Beta2 had had to learn that the problem still exists.
The fix will be included first in 1.1 RC and not in 1.1B?

Rainer
Comment 11 eric.savary 2003-06-11 19:41:22 UTC 
Ok in 645m5-2