Issue 13632 - MacOSX: STLport-4.0.macosx.patch empty
Summary: MacOSX: STLport-4.0.macosx.patch empty
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: 644
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: Martin Hollmichel
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks: 11337 13631
  Show dependency tree
 
Reported: 2003-04-20 10:34 UTC by Unknown
Modified: 2003-06-16 16:44 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
STLport-4.0.macosx.patch (34.96 KB, patch)
2003-04-20 10:36 UTC, Unknown 		no flags Details | Diff
Fixes d.lst to deliver the .dylibs for Mac OS X (495 bytes, patch)
2003-04-26 12:25 UTC, Unknown 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Unknown 2003-04-20 10:34:38 UTC 
The file STLport-4.0.macosx.patch is empty in 644.  Need to add in the file to get STLport to build.
Comment 1 Unknown 2003-04-20 10:36:10 UTC 
Created attachment 5769 [details]
STLport-4.0.macosx.patch
Comment 2 foskey 2003-04-20 11:46:34 UTC 
You can remove the two lines CC=gcc and CXX=g++ from your patch.  This
should come from the settings.

A lot of the patches are apple specific and can be approved without
too much concern.  There are a lot of rework that will require gcc
2.95 testing to do properly though.
Comment 3 foskey 2003-04-20 13:28:46 UTC 
Sorry I misunderstood.  Mac have totally their own patch to make
stlport work.  Since this will only affect mac then this patch is
approved.

You should remove CC= and CXX= from you patch however.
Comment 4 Unknown 2003-04-20 14:52:02 UTC 
Does this mean the CC and CXX lines should also be removed in PORTS as well?  That 
will have to be a seperate issue.
Comment 5 foskey 2003-04-21 04:50:09 UTC 
Try it.  This can be dealt with in one issue though.
Comment 6 Unknown 2003-04-26 12:25:10 UTC 
Created attachment 5906 [details]
Fixes d.lst to deliver the .dylibs for Mac OS X
Comment 7 Unknown 2003-04-26 12:26:45 UTC 
The d.lst was wrong, it would deliver the stlport .dylibs that lots of other things rely 
on to build.

Instructions: 1) cg SCR_DIR/stlport 2) patch -p0 < /file/to/patch
Comment 8 fa 2003-05-16 20:27:28 UTC 
Applied stlport.d.lst.patch to cws_srx644_macosxmerge child workspace.

Copied over the PORTS STLport-4.0.macosx.patch to cws_srx644_macosxmerge
because I was having application issues with the attached patchfile.

Dan
Comment 9 Martin Hollmichel 2003-05-28 10:55:28 UTC 
applied.
Comment 10 Martin Hollmichel 2003-05-28 10:57:31 UTC 
verified.
Comment 11 Martin Hollmichel 2003-06-16 16:44:55 UTC 
closed.