Issue 13557 - Some CJK formats not imported correctly from Excel
Summary: Some CJK formats not imported correctly from Excel
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: code (show other issues)
Version: OOo 1.1 Beta
Hardware: PC Windows 2000
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-17 17:17 UTC by john.marmion
Modified: 2013-08-07 15:15 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Japanese Import Test Case (16.50 KB, application/octet-stream)
2003-04-22 09:41 UTC, john.marmion 		no flags Details
Korean Import Test case (15.00 KB, application/octet-stream)
2003-04-22 10:59 UTC, john.marmion 		no flags Details
Chinese Simple (PRC) Import Test case (16.00 KB, application/octet-stream)
2003-04-22 15:01 UTC, john.marmion 		no flags Details
Chinese Traditional (Taiwan) Import Test Case (16.50 KB, application/octet-stream)
2003-04-22 15:02 UTC, john.marmion 		no flags Details
proof of concept patch (7.81 KB, patch)
2003-04-24 17:21 UTC, john.marmion 		no flags Details | Diff
Simplify the patch following review (6.56 KB, patch)
2003-05-08 15:26 UTC, john.marmion 		no flags Details | Diff
add Default date format for all other languages (7.25 KB, patch)
2003-05-12 15:52 UTC, john.marmion 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description john.marmion 2003-04-17 17:17:28 UTC 
A number of built-in formats exist in Excel for dates and time. We currently 
support Japanese only. We need to extend this to support Chinese and Korean. 
The available CJK Excel built-in formats also change when the Date format in 
the Windows Regional settings are changed. We need to cater for this also.
Comment 1 john.marmion 2003-04-17 17:17:56 UTC 
taking ownership
Comment 2 john.marmion 2003-04-17 17:21:29 UTC 
started
Comment 3 john.marmion 2003-04-17 18:12:34 UTC 
set the target
Comment 4 john.marmion 2003-04-22 09:41:25 UTC 
Created attachment 5792 [details]
Japanese Import Test Case
Comment 5 john.marmion 2003-04-22 10:59:52 UTC 
Created attachment 5803 [details]
Korean Import Test case
Comment 6 john.marmion 2003-04-22 15:01:37 UTC 
Created attachment 5806 [details]
Chinese Simple (PRC) Import Test case
Comment 7 john.marmion 2003-04-22 15:02:53 UTC 
Created attachment 5807 [details]
Chinese Traditional (Taiwan) Import Test Case
Comment 8 john.marmion 2003-04-24 17:21:12 UTC 
Created attachment 5863 [details]
proof of concept patch
Comment 9 john.marmion 2003-04-28 17:07:36 UTC 
To summarise where this is now:

It appears that this patch will satisfy Japanese, Korean and Chinese 
Traditional. There are a couple of minor details with Chinese 
Simplified. The built-in numfmt=32,33,55 and 56 appear correctly in 
the Number Format Dialogue but the hours/minute separator do not look 
correct in the actual cell. But this does seem to be an issue with 
this patch. These numfmts are correctly displayed in Excel when 
exporting to Excel.
Comment 10 john.marmion 2003-05-08 15:26:49 UTC 
Created attachment 6084 [details]
Simplify the patch following review
Comment 11 john.marmion 2003-05-08 15:30:52 UTC 
Note: the previous comment about the glich in the Chinese Simplified 
should read instead of "But this does seem to be an issue with this 
patch" to "But this is *not* caused by this patch".
Comment 12 john.marmion 2003-05-12 15:52:46 UTC 
Created attachment 6145 [details]
add Default date format for all other languages
Comment 13 john.marmion 2003-07-14 18:14:55 UTC 
Checked in fix today into CWS calc16
Comment 14 frank 2003-08-07 15:39:55 UTC 
set to verified
Comment 15 frank 2003-08-07 15:41:44 UTC 
closed verified
Comment 16 frank 2003-08-08 07:53:40 UTC 
closed accidentially, so reopening

Frank
Comment 17 frank 2003-08-08 07:55:07 UTC 
restoring status as fixed.

Frank
Comment 18 john.marmion 2003-08-13 12:28:45 UTC 
re-open to assign to QA
Comment 19 john.marmion 2003-08-13 12:29:09 UTC 
assign to QA
Comment 20 john.marmion 2003-08-13 12:29:38 UTC 
reset to fixed
Comment 21 oc 2003-09-16 08:43:22 UTC 
verified in internal build calc16
Comment 22 oc 2004-03-23 17:07:08 UTC 
closed because fixed