Apache OpenOffice (AOO) Bugzilla – Issue 13533
configure does not set COMPATH correctly the first time
Last modified: 2004-10-26 00:44:59 UTC
When running configure on a fresh build, with no config.cache file in the config_office directory, it will set the COMPATH variable in my Blay.Set file to: /usr/local/gcc-2.95.3/bin, and in my PATH env variable it is: /usr/local/gcc-2.95.3/bin/bin Running configure a second time, you wont see this problem, because if COMPATH is cached, it used that, and strips the last directory off, so it becomes /usr/local/gcc-2.95.3, and is subsequently set to: /usr/local/gcc-2.95.3/bin in PATH! This is because COMPATH is initially set to: /usr/local/gcc-2.95.3/bin/gcc, and the last part is stripped out via the following sed expression. (so /gcc will be stripped out) COMPATH=`echo $COMPATH | $SED "s@/[^/:]*\\\$@@"`; This should be changed to strip $CC out of the path (if it is there), as well as the level before it to! COMPATH=`echo $COMPATH | $SED "s@/[^/:]*[/$CC]*\\\$@@"`; With this change, configure will generate the correct COMPATH everytime!
Created attachment 5714 [details] patch for configure.in
Created attachment 5715 [details] Patch for configure
added keyword and target milestone
re assigning to Ken F
This is already fixed in HEAD/cws_srx644_ooo20030412. That should be backported. See thread around <http://porting.openoffice.org/servlets/ReadMsg?msgId=651324&listName=dev> But as I mentioned in that thread some extra care has to be taken for COMPATH.
OK, I will have a look at that Volker and give it a try. Thanks George
I still see the same problem with 1.1 beta 2! I will attach a patch that basically strips "/bin" off the end of COMPATH (only if COMPATH ends with /bin though - obviously) I think the patch should be ok, as configure (or set_soenv) will add a /bin to the end of COMPATH anyhow, when it is generating the PATH env variable! Here is a new patch for 1.1 beta 2
Created attachment 6692 [details] patch for configure.in (1.1 beta 2)
Now adding re-worked patch for OOO_STABLE_1
Created attachment 6693 [details] patch for configure.in for OOO_STABLE_1
Hi Goerge, your patch is *not* approved, have a look at the following link why: <http://porting.openoffice.org/servlets/ReadMsg?msgId=651384&listName=dev> If you know it works for you enclose your changes with an "if IRIX" condition, but I'm pretty sure it might break W32 builds. I know this part of configure should be reworked, but I have ZERO time right now. Volker
Hi George, It seems this change is a bit controversial and might break other ports as Volker already pointed out. If there is no easy solution right now, why now do as Volker suggested and make sure your change only happens for Irix with some type of ifdef to protect it. Then I am sure we can approve it to get your build in and we can work toghether after 1.1 to figure out a way that works for everyone (if that even exists). Hope this helps, Kevin
re-assigning to Nick Blievers, as I am finishing my work on the Irix port. He will continue on from here, and he may wish to Re- assign this back to Ken F
Accepting...
Hello, I found that this Issue is targetted to 1.0.4. Is this already solved in 1.1 ? if not Can you please retargetting this issue since 1.0.4 is not planned. maybe to 1.1.1 ? Thanks
Changed target
Nick, what is the status of this change?
I haven't had a chance to revisit this, but I believe it will still be a problem. Its not exactly a major problem tho, so am changing to p4
Retarget to 1.1.2. If you want it to be 1.1.1, please change it back with update patch for fix2.
set this P4 to Ooo 2.0 target, can please anybody verify, if the patch make it already into 680 successfully ?
I'll take care.
I just checked config_office/ from cws_srx645_ooo112fix2 and cws_src680_ooo20040509. For all compilers except MSC $COMPATH is used as the path to the compiler executable and it is used without adding /bin when creating the new $PATH. Someone fixed it in the meantime, resolving as fixed.
The comment before qualifies as verified.
close issue.