Issue 13013 - addresstemplate(.cxx and .hxx) have wrong include definitions
Summary: addresstemplate(.cxx and .hxx) have wrong include definitions
Status: CLOSED NOT_AN_OOO_ISSUE
Alias: None
Product: utilities
Classification: Unclassified
Component: code (show other issues)
Version: OOo 1.1 Beta
Hardware: PC All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: Frank Schönheit
QA Contact: Unknown
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-03 22:41 UTC by bluedwarf
Modified: 2004-05-14 14:28 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch for addresstemplate.hxx(rev 1.4) to solve the wrong include definition (506 bytes, patch)
2003-04-03 22:43 UTC, bluedwarf 		no flags Details | Diff
patch for addresstemplate.cxx(rev 1.16) to solve the wrong include definition (662 bytes, patch)
2003-04-03 22:44 UTC, bluedwarf 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description bluedwarf 2003-04-03 22:41:25 UTC 
When I built svtools of 1.1beta(OpenOffice_1_1_beta), gcc compiling
addresstemplate.cxx couldn't find vcl/imagebtn.hxx and cppuhelper/extract.hxx.

vcl/imagebtn.hxx :
I can't find such file in vcl project, maybe vcl/button.hxx was mistaken for it.
To solve this problem, please apply addresstemplate.hxx_1.4.patch which I will
attach later for svtools/inc/addresstemplate.hxx.

cppuhelper/extract.hxx:
I must be typo. extract.hxx is in comphelper. Please apply
addresstemplate.cxx_1.16.patch for svtools/source/dialogs/addresstemplate.cxx.
Comment 1 bluedwarf 2003-04-03 22:43:49 UTC 
Created attachment 5447 [details]
patch for addresstemplate.hxx(rev 1.4) to solve the wrong include definition
Comment 2 bluedwarf 2003-04-03 22:44:31 UTC 
Created attachment 5448 [details]
patch for addresstemplate.cxx(rev 1.16) to solve the wrong include definition
Comment 3 bluedwarf 2003-04-03 22:45:40 UTC 
I have signed JCA, it is no problem to merge this patch to
OpenOffice.org and StarOffice source code.

Best Regareds,
Comment 4 hennes.rohling 2003-05-05 11:25:01 UTC 
@fs: Seems to be your stuff.
Comment 5 Frank Schönheit 2003-05-05 15:12:34 UTC 
Takashi, I suppose your build did something wrong.
If you look at vcl/prj/d.lst, respectively comphelper/prj/d.lst, you
see that the both files in question are explicitly delivered to _two_
locations.

Means, when doing a deliver in comphelper, then
  comphelper/inc/comphelper/extract.hxx
is delivered to _both_ comphelper/extract.hxx _and_ cppuhelper/extract.hxx

Similar situation for vcl/inc/button.hxx, which is delivered to both
vcl/button.hxx and vcl/imagebtn.hxx.

This is for historical reasons: the respective include files were
moved/renamed in the past, and to not adjust all client code, this was
solved by adjusting the "d.lst" files which were used for delivering.

So at the moment, I am somehwat unsteady regarding your patches:
Though they won't hurt, they are not necessary, instead, I really
assume you have a problem in your build setup. Can you please check
this first?
(finally, if this would not be a build problem, this would imply that
all builds on all other platforms would break there, too, which simply
isn't the case :) - this code has compiled for ages on all platforms ...)
Comment 6 Frank Schönheit 2004-01-31 17:51:46 UTC 
any update on this?
Comment 7 Frank Schönheit 2004-05-14 14:28:07 UTC 
no feedback since more than 3 months -> resolving INVALID.

Feel free to reopen if the problem still strikes you.
Comment 8 Frank Schönheit 2004-05-14 14:28:32 UTC 
closing