Issue 12980 - tg_def.mk not W32-tcsh ready
Summary: tg_def.mk not W32-tcsh ready
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: 644
Hardware: PC Windows 2000
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: quetschke
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-03 08:46 UTC by quetschke
Modified: 2004-07-06 01:26 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2003-04-03 08:46:26 UTC 
Branch: cws_srx644_ooo20030412

I just saw that tg_def.mk is not tcsh-aware. (There was an attrib -r in the
log of my last W32-tcsh build.)

Ause, can you please have a look?
Comment 1 quetschke 2003-04-03 08:47:35 UTC 
Set milestone. Please use cws_srx644_ooo20030412 ;-)
Comment 2 hjs 2003-04-16 12:36:08 UTC 
there is no need to keep the files in the "defs" subdirectories
readonly. if all affected directories are treated with "cvs watch off"
the "attrib" command can be removed.
i doubt that this is a beta2 task but you can prepare this change by
doing a local build without the "attrib" and do a "cvs watch off" in
all directories where the "ldump" command breaks (or send me a list).
after beta2 we should commit a "tg_def.mk" without "attrib" and check
if we are complete.
Comment 3 quetschke 2003-04-16 13:05:16 UTC 
I hadn't really had a deep look at tg_def.mk.

If attrib is the only problem then it's no problem.

Just put an $(WRAPCMD) in front of it and everything is OK.

-- Errorlog --
attrib -r defs/wntmsci7
Pfad nicht gefunden -
E:\w1\cws_srx644_ooo20030412cyg\sal\systools\win32\uwinapi\defs
-- Errorlog --

Obviously attrib doesn't like paths with "/" .
Comment 4 hjs 2003-04-16 13:27:37 UTC 
"BUILD_DRIVE$(TNR)" won't be set to any usefull either but it's a
"hamburg only" feature.
btw. i doubt that "$(WRAPCMD)" will help the tcsh to find an attrib
command as it is 4NT internal ;-).
Comment 5 quetschke 2003-04-16 13:45:11 UTC 
Cannot test NT 4, but Win2k says:

ATTRIB [+R | -R] [+A | -A ] [+S | -S] [+H | -H] [[Laufwerk:] [Pfad]
Dateiname] [/S [/D]]

4NT says:
Format:	ATTRIB [/A:[[-+]rhsad] /D /E /I"text" /P /Q /S]
[+|-[ADHNORST]] [@file] files ...

And we use:
	+-attrib -r defs$/$(OUTPATH)
in tg_def.

This should work!

But we could also use an $(CHMOD) instead (to be set in unitools),
set to chmod for tcsh, and to attrib for 4nt. As you like.
Comment 6 hjs 2003-04-16 14:00:23 UTC 
ok, should have said attrib is shell internal (either 4nt or cmd
etc.). a $(CHMOD) would be a fine addition but probably not used widely.
in this special case i would prefer to remove this "attrib" line at all.
Comment 7 quetschke 2003-04-17 11:00:33 UTC 
I will fix this in the next cws_srx644_ooo... branch
Comment 8 Martin Hollmichel 2003-04-29 14:46:03 UTC 
retarget
Comment 9 quetschke 2003-05-11 19:34:21 UTC 
No blocker, removed dependency to 13170
Comment 10 quetschke 2003-06-27 16:07:58 UTC 
Committed to cws_srx645_ooo11rc
Comment 11 Martin Hollmichel 2004-02-15 07:27:37 UTC 
verfied in 1.1.0.
Comment 12 Martin Hollmichel 2004-02-15 07:30:45 UTC 
close issue
Comment 13 quetschke 2004-05-28 18:41:00 UTC 
I only committed tg_def.mk, but not _tg_def. Reopen....
Comment 14 stx123 2004-06-02 08:36:19 UTC 
Would you mind to have a look at the target milestone.
1.1RC didn't sound reasonable.
Comment 15 quetschke 2004-06-02 13:45:29 UTC 
Will be fixed in the next 680er comunity cws.
Comment 16 quetschke 2004-07-06 01:26:16 UTC 
It is fixed in the 680series, but unsolved for 645series.

issue 29676 takes care of this.
Comment 17 quetschke 2004-07-06 01:26:31 UTC 
c