Issue 1291 - WW filter imports floating frames in tables with extra vertical space under the table
Summary: WW filter imports floating frames in tables with extra vertical space under t...
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: 633
Hardware: PC Windows 98
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@www
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-07-22 01:28 UTC by issues@www
Modified: 2013-08-07 14:41 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
The file (59.00 KB, application/msword)
2003-12-06 14:52 UTC, issues@www 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description issues@www 2001-07-22 01:28:24 UTC 
Just open this file and compare to MS Office.
Comment 1 issues@www 2001-07-22 01:29:13 UTC 
Created attachment 409 [details]
The file
Comment 2 issues@www 2001-07-22 01:30:37 UTC 
This is a .doc file...
Comment 3 stefan.baltzer 2001-07-27 14:56:26 UTC 
"Wait and be surprised" is a very poor description. 
Thanks for this enourmos effort to ease our work :-(
Reassigned to Michael.
Comment 4 issues@www 2001-07-28 00:39:47 UTC 
And when I cannot describe it? My english is far not so good as russian (my
mother language), but I want to help! But if you against, so I can just shut up.
:(((
Comment 5 michael.ruess 2001-07-30 16:52:33 UTC 
MRU->CMC: Can you have a look, if there´s something to do. The frames containing
the tables seem to be a bit misplaced.
In the middle of the page there´s a whole Autoform missing.
Comment 6 caolanm 2001-08-02 10:53:46 UTC 
Accept. I get a lot of asserts and some other problems. Some of the tables are
freefloating in frames and some are not. In word tables don't really exist, only
rows that are right under each other. And so our recognition of a table consists
of seeing if there are matching rows one after each other, which is surprisingly
tricky when you consider all the strange ways word combines rows into tables.
Our technique obviously needs to be refined to handle some of the cases
demonstrated in this document. I'd bet that it was based upon a document
imported from an older version of word (95/6), or something 3rd party to end up
like that. You don't generally see textframes in native 97/2000 documents.

Plus the ole object has dissappeared for some reason.
Comment 7 caolanm 2001-08-21 16:57:05 UTC 
The ole object has been shrunk because its anchored inside the table
cell and writer scales objects/graphics to fit in this case. But this
example causes writer to assert, so see issue 1511 for that problem.
Comment 8 caolanm 2001-08-28 16:29:16 UTC 
I misunderstood where the space under the tables in the floating
frames came from, so now its removed in the filter in these cases of a
"floating table". So code to remove the ugly space is checked in. 

The ole2 objects small (invisible) size is a seperate issue requiring
much thought, see issue 1560 for that. So I'll rename this one to
reflect the extra space under tables in frames.
Comment 9 caolanm 2001-08-28 16:31:28 UTC 
Similiar problem as #91622#
Comment 10 caolanm 2001-09-07 11:54:05 UTC 
Extra space under tables in floating frames sorted out in 640h
Comment 11 caolanm 2001-09-07 12:09:15 UTC 
Still not totally happy with the horizontal positioning of the tables,
but those issues are duplicated in issue 1533. Extra space is gone out
of the floaters.
Comment 12 stx123 2001-09-28 10:39:43 UTC 
Caolan, you set target milestone to next build.
Does this mean that you're satisfied with the import in 638?
Comment 13 michael.ruess 2001-10-16 13:15:31 UTC 
looks good in internal 641f. fix will reach the OpenOffice community
in a version with the number 641 or higher.
Comment 14 michael.ruess 2002-07-12 14:55:36 UTC 
Closed.