Issue 123686 - Remove support for building multiple languages in one run of make_installer.pl
Summary: Remove support for building multiple languages in one run of make_installer.pl
Status: CONFIRMED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: 4.1.0-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.1.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-14 12:54 UTC by Andre
Modified: 2017-05-20 10:45 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Andre 2013-11-14 12:54:14 UTC 
The -l option of make_installer.pl can accept multiple languages separated by '#'.  This makes make_installer.pl build installation sets for each language in one run.

This feature is not used when make_installer.pl is started via instsetoo_native/util/makefile.mk.  Its effect can easily be reproduced by starting make_installer.pl several times for each of the languages.
As it just makes the code more complex it should be removed.

Note that multilingual builds (support for more than one language) is a different feature and not affected by this change.
Comment 1 Andre 2013-11-14 12:54:55 UTC 
This is a cleanup task for bug 123531.
Comment 2 SVN Robot 2013-11-14 14:10:36 UTC 
"af" committed SVN revision 1541908 into trunk:
123686: Removed support for building multiple languages in one run.
Comment 3 Andre 2013-11-14 14:26:05 UTC 
Turned @installer::globals::languageproducts into $installer::globals::languageproduct (note the @ and $ at the start and the s and missing s at the end) and changed its uses accordingly.

Had to keep a dummy loop in make_installer.pl that loops exactly once.  It remains necessary so that the 'next' statements still work.  The ca 1500 lines should be refactored into something readable, but there are more important things to do at the moment.
Comment 4 Oliver-Rainer Wittmann 2014-02-10 09:36:19 UTC 
@Andre: Is this issue solved already?
Comment 5 Marcus 2017-05-20 10:45:08 UTC 
Reset the assignee to the default "issues@openoffice.apache.org".