Issue 12359 - license and readme file for windows have unix line end (LF only)
Summary: license and readme file for windows have unix line end (LF only)
Status: CLOSED FIXED
Alias: None
Product: Installation
Classification: Application
Component: ui (show other issues)
Version: 644
Hardware: PC Windows 2000
: P3 Trivial (vote)
Target Milestone: OOo 1.1
Assignee: Olaf Felka
QA Contact: issues@installation
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-14 22:23 UTC by stx123
Modified: 2003-09-08 16:53 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description stx123 2003-03-14 22:23:00 UTC
license.txt and readme.txt file for windows have unix line end (LF only)
Comment 1 Olaf Felka 2003-03-17 09:48:19 UTC
Hi Frank,
please have a look.
Comment 2 michael.bemmer 2003-03-25 08:22:10 UTC
Target this one for beta2.
Comment 3 frank.loehmann 2003-03-27 12:00:48 UTC
FL->Jack: I guess we had this issue already in the past. Was it the
setup application inserting empty paragraphs when using CTRL and LF
why we chose to use LF only?


Comment 4 michael.bemmer 2003-04-02 08:19:41 UTC
Nils, as I'm not sure if Jack still works on that, I re-assign this
one to you.
Comment 5 nils.fuhrmann 2003-04-04 11:16:17 UTC
NF->DV: I need some clarification on this. Is it the case that setup
is only able to deal with unix line ends? In this case, I am not able
to change the behaviour before setup supports dos line ends. 
Comment 6 dirk.voelzke 2003-04-04 12:43:01 UTC
The setup uses the class MultiLineEdit to display the readme/licence
text and that class should support all kinds of lineends.
Comment 7 nils.fuhrmann 2003-04-08 09:58:53 UTC
Jack, do you know why we have done the implementation of the XSLT this
way? Asd Frank mentioned, it is some kind of feature that we deal with
Unix line ends on windows.
Is it (and when yes, how) possible to change the behaviour?
Comment 8 jack.warchold 2003-05-08 12:23:19 UTC
JW-> Unix line end has to be set because the setup routine could not 
handle dos line ends, the setup routine makes blank lines with dos 
CR/LF
Comment 9 nils.fuhrmann 2003-05-08 12:28:20 UTC
NF->DV: As the root cause for the change is within setup
functionality, this issue to you. To support native text formats,
setup has to deal with dos line ends if executed on windows.
Comment 10 dirk.voelzke 2003-05-08 16:55:08 UTC
Hi Nils,

I've checked the setup again and the setup application still displays
the readme/license text right in both versions whether the files use
lf or crlf. I've modified a readme file in the output directory of the
readme project, delivered it, created an installation set and still
everything looks ok to me.
Comment 11 stx123 2003-07-15 12:56:48 UTC
Hi, may be it's time to change the target...
Greetings, Stefan
Comment 12 nils.fuhrmann 2003-07-16 08:20:19 UTC
Jörg, can you please take a look on this? On windows, the line ends
have to be dos copatible. Maybe Bernd can help out working on the XSLT?
Comment 13 epost 2003-07-16 14:54:29 UTC
Hi Bernd,

please modify the readme.xsl as discussed.
Comment 14 bernd.eilers 2003-07-17 11:27:10 UTC
I modified XSLT script, next build should include fix.
Comment 15 Olaf Felka 2003-07-25 10:42:25 UTC
Any hint to test this would be helpfull.
Comment 16 bernd.eilers 2003-07-25 11:12:21 UTC
For the license files a perl script has been integrated into the 
build process to modify line ends. 

OF: to check use a text editor that displays wether unix or dos line 
ends are used and load the license.txt and readme.txt file with that 
editor to verify that DOS lineends are used. Additionally you can 
check wether the setup Application can still display the files 
correctly.
Comment 17 bernd.eilers 2003-07-25 11:15:56 UTC
OF: reassigned to you for testing

Comment 18 Olaf Felka 2003-07-25 11:25:19 UTC
Looks good in CWS readlic
Comment 19 Olaf Felka 2003-07-25 11:26:16 UTC
Verified
Comment 20 Olaf Felka 2003-07-29 15:54:14 UTC
Is ok in current build.