Issue 120619 - [From Symphony]it's slow to open the simple xslx file
Summary: [From Symphony]it's slow to open the simple xslx file
Status: CONFIRMED
Alias: None
Product: Calc
Classification: Application
Component: open-import (show other issues)
Version: 4.0.0-dev
Hardware: All Windows XP
: P3 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-20 02:27 UTC by bjcheny
Modified: 2012-09-10 02:25 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Sample xslx takes long time to open (207.93 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2012-08-20 02:27 UTC, bjcheny 		no flags Details
patch for performance of importing cell style in xslx (3.09 KB, patch)
2012-08-24 09:32 UTC, bjcheny 		no flags Details | Diff
patch for performance of importing cell style in xslx - part 2 (929 bytes, patch)
2012-08-27 06:43 UTC, bjcheny 		companycy: review?
Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description bjcheny 2012-08-20 02:27:41 UTC 
Created attachment 79003 [details]
Sample xslx takes long time to open

It takes long time to open simple xslx file.
Comment 1 bjcheny 2012-08-20 03:10:21 UTC 
It takes almost 300 sec to open sample file on my pc. 
I am working on patch for this problem.
Comment 2 bjcheny 2012-08-24 09:32:05 UTC 
Created attachment 79126 [details]
patch for performance of importing cell style in xslx

The cause is StyleSheetChanged/PageStyleModified action much too frequently.
Thus the patch disables it, and will only do StyleSheetChanged/PageStyleModified once after all properties are set.The changes are:
1. Split the SetOnePropertyValue into SetOnePropertyValueWithoutUpdate and StyleSheetChanged, 
2. Only invoke StyleSheetChanged once after all properties are set by SetOnePropertyValueWithoutUpdate .

It can improve the performance of importing cell style significantly.
Comment 3 bjcheny 2012-08-27 06:43:03 UTC 
Created attachment 79163 [details]
patch for performance of importing cell style in xslx - part 2

Another patch for performance improvement for importing cell styles in xslx.

In this sample, there are up to 28380 records of user-defined Xf to import. It consumes a lot of time. In fact, only 4050 Xf records can be supported in sc module. 

Thus the patch modifies total count of Xf to import to 4050 in oox module,if exceeding.
Comment 4 Terry Yang 2012-08-29 09:46:52 UTC 
Confirm this bug at my side, change bug to confirm status
Comment 5 Yolanda Zhang Ying 2012-08-30 02:09:36 UTC 
Some review comments:
For part1: I think it's ok to do so to reduce import time by limit the useless operation.
For part2: I think it does not make sense to do so, how could we get the 4050 for max support No.? I don't think for OOXML file import, it has such limit for AOO to support more than 4050 styles.
Pls help confirm this limitation, thx!
Comment 6 bjcheny 2012-09-10 02:25:04 UTC 
Comment on attachment 79126 [details]
patch for performance of importing cell style in xslx

Mark this patch duplicated with bug 120824