Issue 12061 - Clean up unitools.mk
Summary: Clean up unitools.mk
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: 644
Hardware: All Windows 2000
: P3 Trivial (vote)
Target Milestone: OOo 1.1 Beta2
Assignee: hjs
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-05 11:40 UTC by quetschke
Modified: 2003-04-16 12:40 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for unitools.mk (1.79 KB, patch)
2003-03-05 11:40 UTC, quetschke 		no flags Details | Diff
Typo! Use this patch for unitools.mk (1.79 KB, patch)
2003-03-05 11:43 UTC, quetschke 		no flags Details | Diff
more cleanup based on previous patch (2.53 KB, patch)
2003-03-19 13:20 UTC, hjs 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2003-03-05 11:40:11 UTC 
The following patch re-orders unitools.mk a bit and adds some comments, it's just
to start with.

Are there other GUI settings than UNX, MAC, WNT and WIN?

Can we drop WIN?

I'd like to have the following groups:

.IF "$(GUI)"=="WNT" && "$(USE_SHELL)"=="4nt"
...
.ELIF "$(GUI)"=="WNT" && "$(USE_SHELL)"!="4nt"
...
.ELIF "$(GUI)"=="MAC"
...
.ELIF "$(GUI)"=="UNX"
...
.ELSE
 ERROR OUT - NO VALID GUI
.ENDIF
Comment 1 quetschke 2003-03-05 11:40:44 UTC 
Created attachment 4986 [details]
Patch for unitools.mk
Comment 2 quetschke 2003-03-05 11:43:32 UTC 
Created attachment 4987 [details]
Typo! Use this patch for unitools.mk
Comment 3 hjs 2003-03-19 13:20:41 UTC 
Created attachment 5159 [details]
more cleanup based on previous patch
Comment 4 hjs 2003-03-19 13:24:19 UTC 
- removed all GUI == MAC
- removed all GUI == WIN
- && not supported in .IF
Comment 5 quetschke 2003-03-28 17:23:09 UTC 
Hi ause, I saw that you committed unitools.mk.newdiff to
cws_srx644_ause02.

I was just going to commit it to cws_srx644_ooo20030412, but you were
faster. ;-)
Comment 6 hjs 2003-03-28 17:36:37 UTC 
fixed but not yet on a ooo branch.
Comment 7 hjs 2003-03-31 10:44:57 UTC 
-
Comment 8 hjs 2003-04-16 12:40:44 UTC 
fixed in ooo20030412