Issue 120237 - Crash when changing a shape background on OSX
Summary: Crash when changing a shape background on OSX
Status: CLOSED FIXED
Alias: None
Product: Draw
Classification: Application
Component: code (show other issues)
Version: 4.0.0-dev
Hardware: All Mac OS X, all
: P2 Major (vote)
Target Milestone: 3.4.1
Assignee: hdu@apache.org
QA Contact:
URL:
Keywords: crash, regression
Depends on: 116758
Blocks: 120230
  Show dependency tree
 
Reported: 2012-07-10 08:50 UTC by hdu@apache.org
Modified: 2012-07-25 07:18 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 3.4.1_release_blocker+

Attachments
backtrace of the crash on OSX for rev 1359210 (7.02 KB, text/plain)
2012-07-10 09:12 UTC, hdu@apache.org 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description hdu@apache.org 2012-07-10 08:50:27 UTC 
To reproduce
- open Draw
- insert a rectangle
- open the Format->Area dialog
- change the fill style to gradient, hatching or bitmap
- press OK
=> Apache OpenOffice crashes
(confirmed on revision 1359210 on the OSX build)
Comment 1 hdu@apache.org 2012-07-10 09:12:31 UTC 
Created attachment 78614 [details]
backtrace of the crash on OSX for rev 1359210

An interesting detail is that in frame 2 pWindow's member _wFlags.windowDying is true which indicates that the crash seems to be caused by an object lifecycle problem.
Comment 2 hdu@apache.org 2012-07-11 14:49:53 UTC 
Fixed with revision 1360181 on trunk:
- a VirtualDevice was reused that was created for a now dead window
- a good workaround on OSX is to use a compatible window as reference instead
- other platforms may have a similar problems, but it was not observed yet

The regression was introduced by the changes for issue 116758
Comment 3 SVN Robot 2012-07-11 15:01:21 UTC 
"hdu" committed SVN revision 1360216 into trunk:
#i120237# cache the updated frame reference in the AquaSalGraphics
Comment 4 jsc 2012-07-12 07:12:37 UTC 
set release blocker flag for 3.4.1
Comment 5 SVN Robot 2012-07-12 12:54:48 UTC 
"hdu" committed SVN revision 1360562 into branches/AOO34:
#i120273# workaround a crash on OSX when a VirtualDevice is reused that was c...
Comment 6 hdu@apache.org 2012-07-12 13:03:14 UTC 
Also fixed on the release branch.
Comment 7 Li Feng Wang 2012-07-20 09:43:22 UTC 
Verify pass on trunk r1362376.
Comment 8 Li Feng Wang 2012-07-25 07:18:22 UTC 
Verified pass with AOo341 branch r1364591 on MAC