Apache OpenOffice (AOO) Bugzilla – Issue 119624
[From Symphony]Group objects in table can not be placed correctly
Last modified: 2017-05-20 11:28:03 UTC
Created attachment 77846 [details] group open the sample file in aoo 3.4, check the grouped objects, the position incorrect
Created attachment 78014 [details] Group shape This sample group line position is also not right.
I am looking into this defect.
I have identified three defect regarding the import and layout of the given Microsoft Word document: (1) horizontal position of the objects inside the tables is wrong. (2) vertical position of the objects inside the table is wrong. (3) the grid layout specified for the page style is applied in AOO also at the paragraphs inside the table. In Microsoft Word 2003 and 2010 the paragraphs inside the table are not layout regarding the given grid. I have a solution for (1) and (2) and will apply patches.
Created attachment 78191 [details] patch to solve (1)
Created attachment 78192 [details] patch to solve (2)
-> zjchen: as you volunteered to take care of this issue I am asking, if you could review my patches for (1) and (2). Thx in advance.
Created attachment 78225 [details] add Word 2010 version case for patch to solve (1) -> Oliver-Rainer Wittmann : The patches look good, if you don't mind I made slightly change, just added one case for identify the MS Word 2012 version in <SwWW8ImplReader::IsObjectLayoutInTableCell(..)>. case 0x8000: // version 12 aka Microsoft Word 2007 + case 0xC000: // version 14 aka Microsoft Word 2010 {
-> zjchen: continue with your change - adding Microsoft Office 2010 version is a very good idea here.
-> Oliver-Rainer Wittmann : The patches for (1) and (2) is OK to me now. Noticed that you assigned this issue to me, however I do not have the permission to commit patches. Would you apply the patches by yourself or other committer? Looking forward to see your solution update in AOO repository to fix related issue:)
-> zjchen: I am sorry. I assigned this issue to you, because I thought that you would work on a solution. May be I have misinterpreted your statement from comment 2. Yes, I can and will apply the patches. Thanks for the review and the improvement regarding the version number for Microsoft Office 2010. Thus, will you work on a solution for problem (3)? If yes, you can attach a corresponding patch. Then I can commit this patch. If not, I can take over this issue.
commited patch to solve problem (1) into trunk - changed file: /sw/source/filter/ww8/ww8graf.cxx, revision 1349210
commited patch to solve problem (2) into trunk - changed file: /sw/source/core/layout/flowfrm.cxx, revision 1349212
-> Oliver-Rainer Wittmann : I investigated problem (3) but have no solution currently. So it is great if you would like to take over this issue:) Sorry for my misleading statement. In comment 2, I just want to express the willing to look at this problem and find a solution. However I find some code are not easy to understand for me, so I ask you for help. And You kindly work out the solution. Thx again:)
-> zjchen: Ok, no problem. I am taking over. May be you can review my patch, if I have found a solution.
Comment on attachment 78191 [details] patch to solve (1) marking review as done and accepted by zjchen
Comment on attachment 78192 [details] patch to solve (2) marking review as done and accepted by zjchen
Reset assigne to the default "issues@openoffice.apache.org".