Issue 117796 - Modification to fpicker/source/win32/filepicker/VistaFilePickerImpl.cxx needs fix in MinGW
Summary: Modification to fpicker/source/win32/filepicker/VistaFilePickerImpl.cxx needs...
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC Windows XP
: P3 Normal (vote)
Target Milestone: 3.4.0
Assignee: tono
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-10 06:10 UTC by tono
Modified: 2017-05-20 10:31 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch to implement conditional compilation (1.55 KB, patch)
2011-04-10 06:10 UTC, tono 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description tono 2011-04-10 06:10:46 UTC 
Created attachment 76336 [details]
Patch to implement conditional compilation

The macro IID_PPV_ARGS() cannot be used in MinGW build and should be manually handled by casting.

Some porting fixes are already implemented in the source but recently one IID_PPV_ARGS is added to the source code.
Comment 1 carsten.driesner 2011-04-11 11:57:58 UTC 
cd->tono: Sorry, that I missed that part. I checked your patch and it looks good to me. Do you want to integrate it into your new CWS mingwport35 or should I put it into one of my CWS?
Comment 2 tono 2011-04-19 10:18:48 UTC 
Fixed in cws mingwport35.
Comment 3 Oliver-Rainer Wittmann 2012-06-13 12:32:54 UTC 
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.