Issue 117792 - glib build breaks on wntmsc.
Summary: glib build breaks on wntmsc.
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC Windows XP
: P1 (highest) Major (vote)
Target Milestone: 3.4.0
Assignee: kurt.zenker
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-10 05:32 UTC by tono
Modified: 2012-03-03 11:15 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch to fix the issue (7.99 KB, patch)
2011-04-10 05:32 UTC, tono 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description tono 2011-04-10 05:32:24 UTC 
Created attachment 76332 [details]
Patch to fix the issue

In local patches for wntmsc build of glib, copy commands in makefiles are substituted with environment variable macro $(GNUCOPY).

It includes posix path notation and cannot be invoked from Microsoft nmake.

Additionally, glib maintainer uses "for" command loop in makefiles. It is dangerous because the return code status may be lost.

And last but not least, the path specifications of glibconfig.h are wrong in the top-level makefile.msc.
Comment 1 philipp.lohmann 2011-04-11 11:07:45 UTC 
add hjs to CC

I just build glib with the patch applied, and had no problems, so the patch should be OK I guess.

I wonder however why $(GNUCOPY) shouldn't work, don't we use that all over the place ? Moreover I can't help but wonder how it compiles here without the patch then.
Comment 2 tono 2011-04-11 11:14:22 UTC 
@pl: Because nmake cannot invoke command with posix absolute path starting with '/', $(GNUCOPY) is only used in makefiles for dmake or gnu make and not in makefiles for nmake, I think.
Comment 3 philipp.lohmann 2011-04-11 15:22:04 UTC 
turns out that in our environmen $(GNUCOPY) is simply "cp" instead of "/usr/bin/cp" which explains why it did not fail here.

@kz: as this is a build breaker for OOo, could you please apply this as masterfix ?
Comment 4 kurt.zenker 2011-04-12 11:37:50 UTC 
The patch has been applied as masterfix for OOO340m1.