Issue 11755 - Correct some warnings in the xml code. Note that this corrects an error
Summary: Correct some warnings in the xml code. Note that this corrects an error
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: definition (show other issues)
Version: 644
Hardware: PC All
: P4 Trivial (vote)
Target Milestone: OOo 1.1 Beta2
Assignee: mikhail.voytenko
QA Contact: issues@xml
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-23 01:53 UTC by foskey
Modified: 2003-05-05 08:18 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch file for sax - correct processing for utf-16 (1.45 KB, patch)
2003-02-23 01:54 UTC, foskey 		no flags Details | Diff
simple clean up of warnings, incomplete. (1.27 KB, patch)
2003-02-23 02:47 UTC, foskey 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description foskey 2003-02-23 01:53:27 UTC 
The code has some warnings in it the attached patch removes those warnings.

The warnings were that code had no effect so this patch may resolve utf-16
issues if any.
Comment 1 foskey 2003-02-23 01:54:08 UTC 
Created attachment 4853 [details]
patch file for sax - correct processing for utf-16
Comment 2 foskey 2003-02-23 02:01:53 UTC 
in package/source/zipapi/ZipFile.cxx:

There is a warning about always being false:

	if ( nTotal > ZIP_MAXENTRIES )

The definition is:

sal_Int32 ZipFile::readCEN()
	throw(IOException, ZipException, RuntimeException)
{
	sal_Int32 nCenLen, nCenPos = -1, nCenOff, nEndPos, nLocPos;
	sal_Int16 nCount, nTotal;


And it is retreived from:
		aGrabber >> nTotal;

It is possible that nTotal should be 32 bits not 16 or unsigned 16.  I
cannot judge this.  Identifying problem to owner.
Comment 3 foskey 2003-02-23 02:47:18 UTC 
Created attachment 4855 [details]
simple clean up of warnings, incomplete.
Comment 4 michael.brauer 2003-02-25 08:03:31 UTC 
.
Comment 5 michael.brauer 2003-02-28 10:56:35 UTC 
Sascha, can you please have a look at this bug and send it to MAV
afterwards.
Comment 6 sascha.ballach 2003-02-28 11:43:12 UTC 
ok, I take it.
Comment 7 sascha.ballach 2003-04-04 09:40:43 UTC 
Hi Mikhail,

I took the fix to solve the problem in xml2utf.cxx. Please have a look 
on the fix of the zip package.

Thanks

Sascha
Comment 8 mikhail.voytenko 2003-04-07 12:21:42 UTC 
.
Comment 9 mikhail.voytenko 2003-04-07 12:26:10 UTC 
The package is fixed.
Indeed, the unsigned 16-bit value should be used.
Comment 10 frank 2003-04-23 14:23:12 UTC 
talked to SAB and MAV and got the Go from them. So I set it to verified.

Frank
Comment 11 mikhail.voytenko 2003-05-05 08:18:20 UTC 
.