Issue 11720 - Exported symbols of shared lib jvmaccess depend on JDK version
Summary: Exported symbols of shared lib jvmaccess depend on JDK version
Status: CLOSED FIXED
Alias: None
Product: udk
Classification: Code
Component: code (show other issues)
Version: 644
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 1.1 Beta2
Assignee: foskey
QA Contact: issues@udk
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-21 15:48 UTC by Stephan Bergmann
Modified: 2003-06-30 19:31 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Patch of fix against 1.1 beta (6.80 KB, patch)
2003-04-25 12:16 UTC, chris
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Stephan Bergmann 2003-02-21 15:48:13 UTC
Shared lib jvmaccess exports C++ symbol
jvmaccess::VirtualMachine::VirtualMachine(.., jint, ..).  Problem is that jint
expands to "long" on JDK 1.3 and to "int" on JDK 1.4, so that the interface of
jvmaccess depends on the JDK used at build time.  Remove this unwanted
dependency by redesigning the argument list of the VirtualMachine class ctor.

Thanks to Pavel Janik and Chris Halls for pointing this out to me.
Comment 1 Stephan Bergmann 2003-02-21 15:51:18 UTC
accepted
Comment 2 pavel 2003-02-21 17:05:02 UTC
I was only hit by the problem and I think it is my duty to report such
problems to save time of other people ;-)
Comment 3 Stephan Bergmann 2003-02-24 09:36:13 UTC
set target
Comment 4 Stephan Bergmann 2003-02-24 15:43:08 UTC
Changed ctor parameter from jint to int.
Comment 5 Stephan Bergmann 2003-03-13 13:05:55 UTC
verified on CWS uno1
Comment 6 Stephan Bergmann 2003-03-31 09:20:06 UTC
closed
Comment 7 foskey 2003-04-10 09:37:58 UTC
Could you please provide more detail on what is fix so that we can
apply this on ALL open tags.
Comment 8 Stephan Bergmann 2003-04-10 10:55:48 UTC
Affected files were
jvmaccess/inc/jvmaccess/virtualmachine.hxx 1.1.12.1
jvmaccess/source/virtualmachine.cxx 1.1.2.1.4.1
jvmaccess/util/cc5_solaris_sparc.map 1.2.2.1.4.1
jvmaccess/util/gcc3_linux_intel.map 1.3.2.1.4.1
jvmaccess/util/msvc_win32_intel.map 1.1.2.1.4.1
(I hope that was all...)
Comment 9 foskey 2003-04-20 13:01:39 UTC
Accepting issue.  Will monitor and close next release if resolved.
Comment 10 piti 2003-04-25 08:04:26 UTC
Undefined                       first referenced
 symbol                             in file
jvmaccess::VirtualMachine::VirtualMachine
(JavaVM_*,int,bool,JNIEnv_*) /export/home/duke/oo_1.1beta_src/solver/6
44/unxsols4.pro/lib/libjvmaccessC52.so.3
ld: fatal: Symbol referencing errors. No output written 
to ../unxsols4.pro/bin/svdem
dmake:  Error code 1, while making '../unxsols4.pro/bin/svdem'
---* TG_SLO.MK *---

ERROR: Error 65280 occurred while 
making /export/home/duke/oo_1.1beta_src/vcl/workben
dmake:  Error code 1, while making 'build_all'
Comment 11 piti 2003-04-25 08:05:32 UTC
Undefined                       first referenced
 symbol                             in file
jvmaccess::VirtualMachine::VirtualMachine
(JavaVM_*,int,bool,JNIEnv_*) .../oo_1.1beta_src/solver/644/unxsols4.pr
o/lib/libjvmaccessC52.so.3
ld: fatal: Symbol referencing errors. No output written 
to ../unxsols4.pro/bin/svdem
dmake:  Error code 1, while making '../unxsols4.pro/bin/svdem'
---* TG_SLO.MK *---

ERROR: Error 65280 occurred while 
making /export/home/duke/oo_1.1beta_src/vcl/workben
dmake:  Error code 1, while making 'build_all'
Comment 12 chris 2003-04-25 12:15:09 UTC
haggai->PITI:  This was fixed *after* the 1.1 beta release.  I'll
attach the patch I made which will apply against 1.1 beta.
Comment 13 chris 2003-04-25 12:16:28 UTC
Created attachment 5882 [details]
Patch of fix against 1.1 beta
Comment 14 Martin Hollmichel 2003-05-07 11:44:25 UTC
mh->waratah: the status of this issue is not clear to me.
Comment 15 foskey 2003-05-08 04:56:13 UTC
Subject to verification on beta2.   Beta 2 broken for jdk 1.3.1 at 
present.  Need someone to download extra packages into jdk 1.3.1 and 
verify that build works correctly.

Must also update documentation to reflect requirement for jdk 1.3.1 
to build beta 2 once (Kevin has decided).
Comment 16 Stephan Bergmann 2003-06-18 15:50:16 UTC
This fix is not really QA-testable.  (Only available tests are unit
tests in sal/test/testtextenc.cxx.)
Comment 17 Stephan Bergmann 2003-06-18 15:51:53 UTC
Forget my last comment, it was meant for another issue...
Comment 18 Stephan Bergmann 2003-06-18 15:55:00 UTC
...and I also reassigned it by mistake!
Comment 19 foskey 2003-06-30 15:41:29 UTC
Resolved.
Comment 20 pavel 2003-06-30 19:31:27 UTC
Yes, closing.