Issue 116845 - smoketest should fail in non-product build when assertions are raised during the test
Summary: smoketest should fail in non-product build when assertions are raised during ...
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: DEV300m99
Hardware: All All
: P3 Trivial (vote)
Target Milestone: 3.4.1
Assignee: Stephan Bergmann
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-07 12:01 UTC by Frank Schönheit
Modified: 2017-05-20 10:30 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Frank Schönheit 2011-02-07 12:01:23 UTC 
Currently, the smoketest (in smoketestoo_native) succeeds even if assertions are
raised during one of the tests.
In order to ... increase the awareness of the significance of assertions as tool
to ensure product quality, the smoketest should fail in such cases.
Comment 1 Stephan Bergmann 2011-02-07 12:39:54 UTC 
@fs:  You should close this as a duplicate of 109142.
Comment 2 Frank Schönheit 2011-02-07 12:50:31 UTC 
@sb: don't think so - aborting assertions are still different from assertions
which "just" make the smoketest fail, aren't they?

*** This issue has been marked as a duplicate of 109142 ***
Comment 3 Frank Schönheit 2011-02-07 12:51:13 UTC 
ouch, clicked the "resolve as duplicate" button too fast ... reopening
Comment 4 Stephan Bergmann 2011-02-07 13:39:42 UTC 
@fs:  Different, in what way?  Either you take "the significance of assertions
as tool to ensure product quality" seriously, or you don't.

I will object to any enlargement of our code heap aimed at a mechanism that lets
smoketest fail upon assertions.  Keep it simple.  Let assertions abort---always.
Comment 5 Frank Schönheit 2011-02-07 13:52:37 UTC 
"In what way"? Compare "every assertion ever thrown during running OOo kills the
process" with "assertions thrown during the smoketest mark the smoketest as
'failed'", please.

I will object any change to our code which we're in no way prepared for.

We already have acceptance problems with the current state, where developers do
not use non-product versions "because there are so many assertions". Having a
non-product version where an assertion isn't an ignorable message box, but
implies termination of the process, won't get any better acceptance. It is
simply too early to implement this.

However, implementing smoketest breakage upon assertions is something which
won't change the daily work directly, but still give assertions at least a
*little* more attention, and thus educate people.
Comment 6 Stephan Bergmann 2011-02-07 14:05:28 UTC 
@fs:  I can understand your motivations, but do not agree with your conclusions.
 If we want to take assertions seriously, we have to bite the bullet and get rid
of their occurrences.  An intermediate step that increases the code heap is not
worth it IMO.
Comment 7 Frank Schönheit 2011-02-07 14:19:44 UTC 
@sb: Well ... we should discuss this with a broader audience, then. I am very
reluctant to introduce the change you propose in issue 109142, simply because I
think we won't get acceptance for this. And such a chance isn't worth anything
without acceptance amongst the developers. If you can convince me that a
majority of developers will accept this - then let's do it. If not, we should do
this incrementally.
Comment 8 mst.ooo 2011-02-08 11:05:31 UTC 
*** Issue 116814 has been marked as a duplicate of this issue. ***
Comment 9 Frank Schönheit 2011-03-04 10:32:25 UTC 
fixed in CWS debuglevels
Comment 10 Frank Schönheit 2011-03-04 12:36:27 UTC 
fs->sb: please verify in CWS debuglevels