Issue 116357 - sal: stop exporting exception class on MinGW
Summary: sal: stop exporting exception class on MinGW
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC Windows, all
: P3 Trivial (vote)
Target Milestone: 3.4.1
Assignee: vg
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-08 04:06 UTC by tono
Modified: 2011-02-26 10:44 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
A patch to disable exporting exception class on MinGW (466 bytes, patch)
2011-01-08 04:08 UTC, tono 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description tono 2011-01-08 04:06:42 UTC 
sal/type.h contains MACRO definitions to make inlined exception class visible on
gcc platforms. MinGW does not needs it.

Moreover, after 4.5.x, MinGW gcc instanciate all inlined member functions in
visible classes. So we should stop exporting exception classes on MinGW.
Comment 1 tono 2011-01-08 04:08:25 UTC 
Created attachment 75502 [details]
A patch to disable exporting exception class on MinGW
Comment 2 tono 2011-01-08 04:14:45 UTC 
Started in cws mingwport33.
Comment 3 tono 2011-01-09 00:56:56 UTC 
Fixed in cws mingwport33.
Comment 4 tono 2011-01-09 01:06:23 UTC 
@vg: Please verify. Although the MinGW buildbot is not working well, I have
tested MinGW build locally. MSVC and un*x builds are confirmed on buildbots.
Comment 5 tono 2011-02-26 10:44:33 UTC 
Closing the issue as the fix has been integrated.