Issue 113061 - svx: dubious self-assign in svx/source/gallery2/gallery1.cxx
Summary: svx: dubious self-assign in svx/source/gallery2/gallery1.cxx
Status: CLOSED FIXED
Alias: None
Product: Draw
Classification: Application
Component: code (show other issues)
Version: DEV300m84
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: 3.4.1
Assignee: ooo
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks: 113062
  Show dependency tree
 
Reported: 2010-07-09 20:17 UTC by caolanm
Modified: 2017-05-20 10:22 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
dubious self-assign (637 bytes, patch)
2010-07-09 20:17 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2010-07-09 20:17:06 UTC 
operation on '((Gallery*)this)->Gallery::nLastFileNumber' may be undefined, i.e.

nLastFileNumber= ... ++nLastFileNumber

probably the attached patch is intended
Comment 1 caolanm 2010-07-09 20:17:51 UTC 
Created attachment 70474 [details]
dubious self-assign
Comment 2 philipp.lohmann 2010-11-15 12:08:20 UTC 
committed in CWS vcl117

but actually this should not be undefined, should it ? Anyway it looks clearer
now IMHO.
Comment 3 philipp.lohmann 2010-11-25 10:26:46 UTC 
v