Issue 112688 - Build breaks in module shell
Summary: Build breaks in module shell
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.0
Hardware: Other Windows, all
: P1 (highest) Trivial (vote)
Target Milestone: ---
Assignee: ooo
QA Contact: issues@l10n
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-25 12:06 UTC by oliver.bolte
Modified: 2013-08-07 15:02 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Workaround to fix the problem (1.33 KB, text/plain)
2010-06-28 08:35 UTC, oliver.bolte 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description oliver.bolte 2010-06-25 12:06:32 UTC 
Change from CWS locales33a:

Entering /cygdrive/o/DEV300/ooo/shell/source/win32/shlxthandler/res

: &&     PATH=${PATH+${PATH}:}/cygdrive/o/DEV300/wntmsci12.pro/bin
../../../../wntmsci12.pro/bin/lngconvex -ulf
../../../../common.pro/misc/shlxthdl/shlxthdl.ul f -rc
../../../../wntmsci12.pro/res/shlxthdl.rc -rct rctmpl.txt -rch rcheader.tx t
-rcf rcfooter.txt ERROR: Duplicated ms id 1027 found for the languages ca-XV and
ca !!!! This does not work in microsoft resources Please remove one! dmake: 
Error code 255, while making '../../../../wntmsci12.pro/res/shlxthdl.rc'
Comment 1 ooo 2010-06-25 12:14:40 UTC 
Investigating.
Comment 2 rt 2010-06-25 15:48:25 UTC 
BTW, the same breakage we see at 
  desktop/win32/source/setup
  desktop/win32/source/rebase
and
  crashrep/source/win32
Comment 3 ooo 2010-06-25 15:53:02 UTC 
I successfully built module shell for wntmsci12.pro and could not reproduce.
However, in a build with all languages apparently all languages are lumped
together in that shlxthdl.rc resource (and probably same for the others) and
hence the message, just where is it defined that ca-XV would be part of such a
build? Remove it. I can then later see how we can manage that nasty ca-XV in
parallel to ca.
Comment 4 oliver.bolte 2010-06-28 08:35:08 UTC 
Created attachment 70251 [details]
Workaround to fix the problem
Comment 5 oliver.bolte 2010-06-28 09:18:43 UTC 
Fixed as revision: 200b878e2e92
Comment 6 oliver.bolte 2010-06-28 10:45:21 UTC 
.
Comment 7 ooo 2010-06-28 11:05:36 UTC 
A crude attempt.. Note that this again enables ca-XV to creep in as document
content, which previous changes tried to avoid.
Comment 8 ooo 2010-06-28 15:57:24 UTC 
Created issue 112762 as followup.

@obo:
I understand that
-    { LANGUAGE_CATALAN,                     "ca", "XV" },
+    { LANGUAGE_USER_CATALAN_VALENCIAN,                     "ca", "XV" },

helped in that it provides a mapping to a now unique MS-LangID, but why
would also this change be necessary?
-    { LANGUAGE_USER_CATALAN_VALENCIAN,      "ca", "ES" },
+//    { LANGUAGE_USER_CATALAN_VALENCIAN,      "ca", "ES" },
Comment 9 oliver.bolte 2010-06-28 16:25:23 UTC 
I simply was in hurry. We have no ca-ES installation sets and I'm not really
familiar with l10n stuff. You can create a new CWS and fix your issue - it was a
workaround, nothing else.
Comment 10 Marcus 2010-10-16 00:57:20 UTC 
closed