Issue 112604 - configure: reject hsqldb 1.8.1.x
Summary: configure: reject hsqldb 1.8.1.x
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: configure (show other issues)
Version: current
Hardware: Unknown All
: P3 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: rene
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-22 15:18 UTC by rene
Modified: 2017-05-20 10:22 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description rene 2010-06-22 15:18:00 UTC
Hi,

we should prohibit building against hsqldb 1.8.1 as the following:

diff --git a/configure.in b/configure.in
--- a/configure.in
+++ b/configure.in
@@ -3990,7 +3990,7 @@
         fi
         AC_CHECK_FILE($HSQLDB_JAR, [],
                [AC_MSG_ERROR(hsqldb.jar not found.)], [])
-        AC_MSG_CHECKING([whether hsqldb is >= 1.8.0.9])
+        AC_MSG_CHECKING([whether hsqldb is 1.8.0.x])
         export HSQLDB_JAR
         if $PERL -e 'use Archive::Zip;
             my $file = "$ENV{'HSQLDB_JAR'}";
@@ -4003,7 +4003,7 @@
 		        ($t, $version) = split (/:/,$line);
 		        $version =~ s/^\s//;
 		        ($a, $b, $c, $d) = split (/\./,$version);
-		        if (($c == "0" && $d > "8") || $c > 0)  {
+		        if ($c == "0" && $d > "8")  {
 		            exit 0;
 		        } else {
 		            exit 1;
@@ -4015,7 +4015,7 @@
             }'; then
             AC_MSG_RESULT([yes])
          else
-            AC_MSG_ERROR([no, hsqldb >= 1.8.0.9 is needed])
+            AC_MSG_ERROR([no, you need hsqldb >= 1.8.0.9 but < 1.8.1])
          fi
 else
     AC_MSG_RESULT([internal])

to prevent stuff like http://de.openoffice.org/servlets/ReadMsg?list=dev&msgNo=44128
Comment 1 rene 2010-06-22 15:19:45 UTC
CC issues@dba
Comment 2 rene 2010-06-22 16:58:47 UTC
committed myself to configure25
Comment 3 rene 2010-06-22 16:59:01 UTC
.
Comment 4 lohmaier 2010-06-23 23:21:07 UTC
verified in cws