Issue 11140 - OOO_STABLE_1_PORTS/X11: soffice.sh needs to quote pathnames
Summary: OOO_STABLE_1_PORTS/X11: soffice.sh needs to quote pathnames
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.1
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1.1
Assignee: ed
QA Contact: issues@porting
URL:
Keywords: oooqa
Depends on:
Blocks:
 
Reported: 2003-02-03 02:57 UTC by terryt
Modified: 2004-02-27 13:06 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
cd to SRC_ROOT/sysui, patch -p0 < /path/to/patchfile, rebuild sysui (896 bytes, patch)
2003-02-03 02:59 UTC, terryt 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description terryt 2003-02-03 02:57:05 UTC 
If a user installs OOo 1.0.1 into a path that contains shell special characters, such as 
spaces (e.g. "/Applications/OOo Final Beta/OpenOffice.org1.0.1"), then attempts to run 
"spadmin", the "soffice.sh" script will fail with the following type of errors :

ls: /Applications/OOo: No such file or directory
ls: Beta/OpenOffice.org1.0.1/program/spadmin: No such file or directory
ls: Final: No such file or directory

This is because "soffice.sh" doesn't correctly quote parameters being passed to it.

Although discovered in Mac OS X (where users are more likely to have paths with 
spaces in them), this bug likely occurs on other platforms.

The fix is to simply quote the $0 parameter in the offending line(s) of "soffice.sh".
Comment 1 terryt 2003-02-03 02:59:45 UTC 
Created attachment 4538 [details]
cd to SRC_ROOT/sysui, patch -p0 < /path/to/patchfile, rebuild sysui
Comment 2 terryt 2003-09-02 08:47:48 UTC 
Since I now have the privileges, I get to change status on my own 
bug <grin>.

Added oooqa keyword.

Ed fixed this in the Mac OS X specific version of "soffice", but it 
probably should be fixed in CVS.
Comment 3 terryt 2003-12-26 08:55:58 UTC 
It seems this has been fixed in the current OOo 1.1.1 (cws_fix645_ooo111fix2 at 
least), although for some reason, the soffice.sh file no longer has any CVS 
keywords in it, so I can't easily tell who fixed the problem, and when.

I will change the resolution to fixed, but someone else might want to confirm 
with the final OOo 1.1.1 version before closing.
Comment 4 Martin Hollmichel 2004-02-27 13:06:07 UTC 
close issue